X-Authentication-Warning:	delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient:	geda-user AT delorie DOT com
X-Mailer:	exmh version 2.8.0 04/21/2012 with nmh-1.7+dev
X-Exmh-Isig-CompType:	repl
X-Exmh-Isig-Folder:	inbox
From:	"karl AT aspodata DOT se [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
To:	geda-user AT delorie DOT com
Subject:	Re: [geda-user] SAB processing patches
In-reply-to:	<alpine.DEB.2.21.2011302045040.2894@nimbus>
References:	<e4ff3c96-939b-a93e-a32f-5e938b6daa63 AT epilitimus DOT com> <alpine DOT DEB DOT 2 DOT 21 DOT 2011302045040 DOT 2894 AT nimbus>
Comments:	In-reply-to Roland Lutz <rlutz AT hedmen DOT org>
	message dated "Mon, 30 Nov 2020 21:31:18 +0100."
Mime-Version:	1.0
Message-Id:	<20201130220505.0AE4282C54FD@turkos.aspodata.se>
Date:	Mon, 30 Nov 2020 23:05:05 +0100 (CET)
X-Virus-Scanned:	ClamAV using ClamSMTP
Reply-To:	geda-user AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	geda-user AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

Roland Lutz:
...
> >From a first glance, this looks good.  I'll have to go through the patches 
> and understand how they work in detail in order to say anything 
> substantiated, but there's some formal things I noticed when skimming 
> through:
> 
> - Functions which are only used inside the file in which they are defined 
> should be "static" (not visible in the global namespace).
> 
> - New C code should follow the C coding style of the project:
>    - two spaces indentation,
>    - one space character before a parameter list(!) and before and after an
>      operator, and before (but not after) a pointer asterisk,
>    - the opening brace goes on the same line for control structures but on
>      a separate line for function headers.
>    Code on one level of indentation should always be indented consistently.
...
> - Lines in source and text files should be less than 80 characters long. 
> Lines in commit messages should not be longer than 72 characters, and (if 
> one feels pedantic) 64 characters on the first line.
...

Why not provide a recipy for the program "indent", and be done with it.

Regards,
/Karl Hammar

- Raw text -