| www.delorie.com/archives/browse.cgi | search |
| X-Authentication-Warning: | delorie.com: mail set sender to geda-user-bounces using -f |
| X-Recipient: | geda-user AT delorie DOT com |
| X-Original-DKIM-Signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=prochac.sk; |
| s=default; t=1453047237; | |
| bh=uRCuzgKjbPxPO7/ICjLwvEjK9/zE7lbhYXoefGd4XZk=; | |
| h=Subject:To:References:From:Date:In-Reply-To; | |
| b=TlAMAO1gJFu92lJjf+NKBkryfFRjAjkuniWp3q5xjqaucSry/3tFLvQtypZf65lM2 | |
| eegW9sHll0qLPhWiLJqRWvRdgeRDSdgdec4QawH7is9oHqtVoDrM2sl9naw7XkuXUQ | |
| 0jjWchqVNOGgWTYGK5XWPFGr8zJVfLGtoZmzPg0E= | |
| X-Clacks-Overhead: | "GNU Terry Pratchett" |
| Subject: | Re: [geda-user] cleaner version of fixes to file format plugin |
| To: | geda-user AT delorie DOT com |
| References: | <CAC4O8c88EnAJ1H4YL4rj2O10ihZAz_NYDMSBAWEmdknMNu2b4A AT mail DOT gmail DOT com> |
| <CAJXU7q8AtP=UOZrM1e+7Vmimc5kxOjyNrrGjqxcanRTjBWsVDA AT mail DOT gmail DOT com> | |
| From: | "Milan Prochac (milan AT prochac DOT sk) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com> |
| Message-ID: | <569BBE0A.3060407@prochac.sk> |
| Date: | Sun, 17 Jan 2016 17:15:06 +0100 |
| User-Agent: | Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 |
| Thunderbird/38.5.1 | |
| MIME-Version: | 1.0 |
| In-Reply-To: | <CAJXU7q8AtP=UOZrM1e+7Vmimc5kxOjyNrrGjqxcanRTjBWsVDA@mail.gmail.com> |
| X-Spam-Status: | No, score=-101.0 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE, |
| USER_IN_WHITELIST autolearn=ham autolearn_force=no version=3.4.0 | |
| X-Spam-Checker-Version: | SpamAssassin 3.4.0 (2014-02-07) on angua.bastl.sk |
| Reply-To: | geda-user AT delorie DOT com |
| Errors-To: | nobody AT delorie DOT com |
| X-Mailing-List: | geda-user AT delorie DOT com |
| X-Unsubscribes-To: | listserv AT delorie DOT com |
This is a multi-part message in MIME format.
--------------020203080205080903060406
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
On 17. 1. 2016 13:24, Peter Clifton (petercjclifton AT googlemail DOT com) [via
geda-user AT delorie DOT com] wrote:
> No // comments please.
>
These was just missed durin cleanup, these lines were supposed to be
deleted. it's already cleaned (I use // comments as simplest way to mark
code to be deleted)
> is_default - is that supposed to be a boolean, or a number?
>
Already changed to bool...
> If boolean - don't use int :)
>
> (Not a comprehensive code-review... I already said, I don't have time
> for this until the code-sprint after FOSDEM).
>
and lot of other changes ... including code formatting
Milan
> Peter
>
> On 17 January 2016 at 00:34, Britton Kerin (britton DOT kerin AT gmail DOT com
> <mailto:britton DOT kerin AT gmail DOT com>) [via geda-user AT delorie DOT com
> <mailto:geda-user AT delorie DOT com>] <geda-user AT delorie DOT com
> <mailto:geda-user AT delorie DOT com>> wrote:
>
>
> The attached diff is against the version bert checked in but it
> lacks introduced bugs and most irrelevant junk.
>
> I also pushed it to LP1532611_fixes
>
>
--------------020203080205080903060406
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-MIME-Autoconverted: from 8bit to quoted-printable by angua.bastl.sk id u0HGDvww020441
<html>
<head>
<meta content=3D"text/html; charset=3Dutf-8" http-equiv=3D"Content-Ty=
pe">
</head>
<body bgcolor=3D"#FFFFFF" text=3D"#000000">
<div class=3D"moz-cite-prefix">On 17. 1. 2016 13:24, Peter Clifton
(<a class=3D"moz-txt-link-abbreviated" href=3D"mailto:petercjclifto=
n AT googlemail DOT com">petercjclifton AT googlemail DOT com</a>) [via <a class=3D"moz=
-txt-link-abbreviated" href=3D"mailto:geda-user AT delorie DOT com">geda-user AT de=
lorie.com</a>] wrote:<br>
</div>
<blockquote
cite=3D"mid:CAJXU7q8AtP=3DUOZrM1e+7Vmimc5kxOjyNrrGjqxcanRTjBWsVDA AT mail DOT gm=
ail.com"
type=3D"cite">
<div dir=3D"ltr">
<div>
<div>
<div>No // comments please.<br>
<br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
These was just missed durin cleanup, these lines were supposed to be
deleted. it's already cleaned (I use // comments as simplest way to
mark code to be deleted)<br>
<br>
<blockquote
cite=3D"mid:CAJXU7q8AtP=3DUOZrM1e+7Vmimc5kxOjyNrrGjqxcanRTjBWsVDA AT mail DOT gm=
ail.com"
type=3D"cite">
<div dir=3D"ltr">
<div>
<div>is_default - is that supposed to be a boolean, or a
number?<br>
<br>
</div>
</div>
</div>
</blockquote>
<br>
Already changed to bool...<br>
<br>
<blockquote
cite=3D"mid:CAJXU7q8AtP=3DUOZrM1e+7Vmimc5kxOjyNrrGjqxcanRTjBWsVDA AT mail DOT gm=
ail.com"
type=3D"cite">
<div dir=3D"ltr">
<div>If boolean - don't use int :)<br>
<br>
</div>
<div>(Not a comprehensive code-review... I already said, I don't
have time for this until the code-sprint after FOSDEM).<br>
</div>
<div><br>
</div>
</div>
</blockquote>
<br>
and lot of other changes ...=C2=A0 including code formatting<br>
<br>
Milan<br>
<br>
<blockquote
cite=3D"mid:CAJXU7q8AtP=3DUOZrM1e+7Vmimc5kxOjyNrrGjqxcanRTjBWsVDA AT mail DOT gm=
ail.com"
type=3D"cite">
<div dir=3D"ltr">Peter<br>
</div>
<div class=3D"gmail_extra"><br>
<div class=3D"gmail_quote">On 17 January 2016 at 00:34, Britton
Kerin (<a moz-do-not-send=3D"true"
href=3D"mailto:britton DOT kerin AT gmail DOT com">britton DOT kerin AT gmail DOT c=
om</a>)
[via <a moz-do-not-send=3D"true"
href=3D"mailto:geda-user AT delorie DOT com">geda-user AT delorie DOT com</=
a>]
<span dir=3D"ltr"><<a moz-do-not-send=3D"true"
href=3D"mailto:geda-user AT delorie DOT com" target=3D"_blank">ged=
a-user AT delorie DOT com</a>></span>
wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir=3D"ltr"><br>
<div>The attached diff is against the version bert checked
in but it lacks introduced bugs and most irrelevant
junk.</div>
<div><br>
</div>
<div>I also pushed it to=C2=A0LP1532611_fixes</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>
--------------020203080205080903060406--
| webmaster | delorie software privacy |
| Copyright © 2019 by DJ Delorie | Updated Jul 2019 |