X-Authentication-Warning:	delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient:	geda-user AT delorie DOT com
X-Original-DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=googlemail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:content-type;
	bh=ODdvJ8lLEYTxt416U0tfcenGhxcNQMTXNbvrKCsKMfQ=;
	b=V+IN0BM1DL4r8acdCLq3UukK4FbUPzfNidu7vap2h6i+LHqhhZCjgjEwKxs+ldsSRY
	HsJsI2ucEPKx1tFoAWjaDM5WEtNwQqzLUOFlvtr6YDCQQnU+PnzQhG2Py5cIdpAF5wfq
	if8WBWcWmzIOtbJQr1fQTjRggFfs3ad8jlBk/9P9M65gCbu1PvUw1VLCyBjdaeWpxiyf
	cBz/7hnRQXHUKy+TlAcvVK2TEi5u3N7U6QNic/IcB9Mh9vJ+Xz8u069e0f1LAZDv0Wc4
	GSfZ8WnG23biSaZOk4wLdBPozDHlbqjiHqGvzfm7bJrzPiIaOvMeJ5O+QgoneV0CsH4z
	LUcg==
X-Google-DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:mime-version:in-reply-to:references:date
	:message-id:subject:from:to:content-type;
	bh=ODdvJ8lLEYTxt416U0tfcenGhxcNQMTXNbvrKCsKMfQ=;
	b=G6uTz1h/GXC/uiHW5uUVZXRnEW8e4Ipe1N+2VO49D3uyCDqNh8GLhjrDJ2bFiySbVO
	+MwJQIEtGt6YsFJXbkITsRG1Kj6FpXV3cJQEBJvrjA8IzyxpV9+v+4b6G9l97UtTTfFJ
	7eeffgEXN14RXnGgijLbV2SwYMYua8epVV2X3AJVjzUhhSgR47tO+g0g0JU/6XFZKH7I
	PUyL9lT8ofmcOUF1Roa29k+oduRHWXfX1+bvafgExinc6vCIrUfjo9JVF2KoFA7Oh/O+
	+Bv50NS/1gKdQv03cDm9pWwPrPrDRCKX58iqM4MYcU3XUpxErvSHSoAW5etCblNVXk2N
	3fng==
X-Gm-Message-State:	ALoCoQmRSJco8MgpHr/KvVTiQ5PCLtFkminkRymrjefdekNeGkkl/xKdAtbAm36FbNpOjrPBSuVBn5IegXHIKez8t94On4KyRw==
MIME-Version:	1.0
X-Received:	by 10.202.85.146 with SMTP id j140mr15041832oib.4.1453033466963;
	Sun, 17 Jan 2016 04:24:26 -0800 (PST)
In-Reply-To:	<CAC4O8c88EnAJ1H4YL4rj2O10ihZAz_NYDMSBAWEmdknMNu2b4A@mail.gmail.com>
References:	<CAC4O8c88EnAJ1H4YL4rj2O10ihZAz_NYDMSBAWEmdknMNu2b4A AT mail DOT gmail DOT com>
Date:	Sun, 17 Jan 2016 12:24:26 +0000
Message-ID:	<CAJXU7q8AtP=UOZrM1e+7Vmimc5kxOjyNrrGjqxcanRTjBWsVDA@mail.gmail.com>
Subject:	Re: [geda-user] cleaner version of fixes to file format plugin
From:	"Peter Clifton (petercjclifton AT googlemail DOT com) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
To:	gEDA User Mailing List <geda-user AT delorie DOT com>
Reply-To:	geda-user AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	geda-user AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

--001a113d216ea53024052986b7e0
Content-Type: text/plain; charset=UTF-8

No // comments please.

is_default - is that supposed to be a boolean, or a number?

If boolean - don't use int :)

(Not a comprehensive code-review... I already said, I don't have time for
this until the code-sprint after FOSDEM).

Peter

On 17 January 2016 at 00:34, Britton Kerin (britton DOT kerin AT gmail DOT com) [via
geda-user AT delorie DOT com] <geda-user AT delorie DOT com> wrote:

>
> The attached diff is against the version bert checked in but it lacks
> introduced bugs and most irrelevant junk.
>
> I also pushed it to LP1532611_fixes
>

--001a113d216ea53024052986b7e0
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div><div><div>No // comments please.<br><br></div>is_defa=
ult - is that supposed to be a boolean, or a number?<br><br></div>If boolea=
n - don&#39;t use int :)<br><br></div><div>(Not a comprehensive code-review=
... I already said, I don&#39;t have time for this until the code-sprint af=
ter FOSDEM).<br></div><div><br></div>Peter<br></div><div class=3D"gmail_ext=
ra"><br><div class=3D"gmail_quote">On 17 January 2016 at 00:34, Britton Ker=
in (<a href=3D"mailto:britton DOT kerin AT gmail DOT com">britton DOT kerin AT gmail DOT com</a>)=
 [via <a href=3D"mailto:geda-user AT delorie DOT com">geda-user AT delorie DOT com</a>] <=
span dir=3D"ltr">&lt;<a href=3D"mailto:geda-user AT delorie DOT com" target=3D"_bl=
ank">geda-user AT delorie DOT com</a>&gt;</span> wrote:<br><blockquote class=3D"gm=
ail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-le=
ft:1ex"><div dir=3D"ltr"><br><div>The attached diff is against the version =
bert checked in but it lacks introduced bugs and most irrelevant junk.</div=
><div><br></div><div>I also pushed it to=C2=A0LP1532611_fixes</div></div>
</blockquote></div><br></div>

--001a113d216ea53024052986b7e0--

- Raw text -