X-Authentication-Warning:	delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient:	geda-user AT delorie DOT com
X-Original-DKIM-Signature:	v=1; a=rsa-sha256; c=simple; d=mail.ud03.udmedia.de; h=
	subject:to:references:from:message-id:date:mime-version
	:in-reply-to:content-type:content-transfer-encoding; s=beta; bh=
	J8Xw/lWHxttHsj0gCzWyrOgVpD6HQ5H2wK38qBlILm8=; b=bvKazXS6pmoq1zRK
	AzQGgqsnqpRIu2Aqyhc+qJ1poY/1B4smVP93VdZFEwa3RzmXvnqWPPOS1fAeEvIF
	u9fdz9h5RW84Mh+3AFn/ZNZKF6M8F4IhpC5RvzkwktBJwDX9IU2829mbuvVJFsOO
	sb9Tb4ViI/5aXTe4Jwg+aPSspys=
Subject:	Re: [geda-user] DRC violation discovery order fix options
To:	geda-user AT delorie DOT com
References:	<CAC4O8c-84zCCvrgRz0gJN3xxe4d+NNcP4m1aX6cj-gi8r+vQmQ AT mail DOT gmail DOT com>
From:	"Markus Hitter (mah AT jump-ing DOT de) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
Message-ID:	<55FFCE93.7070004@jump-ing.de>
Date:	Mon, 21 Sep 2015 11:32:03 +0200
User-Agent:	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
	Thunderbird/38.2.0
MIME-Version:	1.0
In-Reply-To:	<CAC4O8c-84zCCvrgRz0gJN3xxe4d+NNcP4m1aX6cj-gi8r+vQmQ@mail.gmail.com>
Reply-To:	geda-user AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	geda-user AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

Am 20.09.2015 um 02:11 schrieb Britton Kerin:
> well reordering the DRC violations is hard due [...]

I've looked at the commit you pushed. Difficult to review, because it
does at least three things in one commit:

- Lots of whitespace editing (removal of whitespace at line ends).

- Change something in main.c.

- Change something in the HID.

It's a good idea to have one commit changing only one issue. Think about
what happens when one of these changes turns out to be a bad idea later;
a revert wouldn't work. Keeping focus also helps a lot in understanding
wether edits do what they intend to do.


Markus

-- 
- - - - - - - - - - - - - - - - - - -
Dipl. Ing. (FH) Markus Hitter
http://www.jump-ing.de/

- Raw text -