X-Authentication-Warning:	delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient:	geda-user AT delorie DOT com
X-Original-DKIM-Signature:	v=1; a=rsa-sha256; c=simple; d=mail.ud03.udmedia.de; h=
	message-id:date:from:mime-version:to:subject:content-type
	:content-transfer-encoding; s=beta; bh=fCz6AF/bIeZYn31FSwl6BkLXk
	+X/EjD1H+gGIHnwnUk=; b=IZS2CMdBBR4rAF4VIxSfosi6IGBoD3MYRRV1W2EZm
	gtaVwlVtYfgfNeGHlC/KQsmLpWT/UAhCyd0pThV8kaZxNkIIzQnmBIdmd9Kv4pME
	17bOgdBYOIeBWNa0wOTNhIRv8LMWxC6D6kEvjJYUDd4cVpYlbCUPly/paMUtFe0/
	zg=
Message-ID:	<55E2F5B1.7070507@jump-ing.de>
Date:	Sun, 30 Aug 2015 14:23:13 +0200
From:	"Markus Hitter (mah AT jump-ing DOT de) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
User-Agent:	Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version:	1.0
To:	geda-user AT delorie DOT com
Subject:	[geda-user] command.c/.h
Reply-To:	geda-user AT delorie DOT com

While stepping through the sources, I find the files command.c and command.h. command.h defines these two functions:

void ExecuteUserCommand (char *);
void CallActionProc (char *action, char **arg, int argc);

However, neither of them is used anywhere, grep'ing for them brings up nothing but the hit in command.c/.h its self. Looking at the source, these two files apparently implement a vi-like interface:

  Message ("following commands are supported:\n"
	   "  Command()   execute an action command (too numerous to list)\n"
	   "              see the manual for the list of action commands\n"
	   "  h           display this help message\n"
	   "  l  [file]   load layout\n"
	   "  le [file]   load element to buffer\n"
	   "  m  [file]   load layout to buffer (merge)\n"
	   "  q           quits the application\n"
	   "  q!          quits without save warning\n"
	   "  rn [file]   read in a net-list file\n"
	   "  s  [file]   save layout\n"
	   "  w  [file]   save layout\n"
	   "  wq [file]   save layout and quit\n");

Anybody aware of where or how this is used? Any user of this interface? If unused I'd remove it to remove one level of obfuscation.

Tracked at https://bugs.launchpad.net/pcb/+bug/1490264


Markus

-- 
- - - - - - - - - - - - - - - - - - -
Dipl. Ing. (FH) Markus Hitter
http://www.jump-ing.de/

- Raw text -