Message-ID:	<39AD1BF3.139CB5DB@softhome.net>
Date:	Wed, 30 Aug 2000 16:36:35 +0200
From:	Laurynas Biveinis <lauras AT softhome DOT net>
X-Mailer:	Mozilla 4.74 [en] (Win98; U)
X-Accept-Language:	lt,en
MIME-Version:	1.0
To:	djgpp-workers AT delorie DOT com
CC:	Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>, Jason Green <mail AT jgreen4 DOT fsnet DOT co DOT uk>
Subject:	Re: Symify fixes
References:	<226lqssqgqp6i9nk82rvrqhl9aaia029e9 AT 4ax DOT com> <7458-Mon28Aug2000203504+0300-eliz AT is DOT elta DOT co DOT il> <ltflqs8ouggncaukmesirq7rsbsi4umrj5 AT 4ax DOT com> <8011-Mon28Aug2000234727+0300-eliz AT is DOT elta DOT co DOT il> <ttvnqs0p0rib0eja7eiijst64vbgp9tl1b AT 4ax DOT com>
Reply-To:	djgpp-workers AT delorie DOT com

I've started integrating it and have one minor comment:

> bail(): Prints an error message to stderr and quits.

> +/* bail(): Print MSG to stderr and quit */
> +static void bail(const char *msg)
> +{
> +  assert(msg);
> +
> +  fprintf(stderr, "SYMIFY ERROR: %s\n", msg);
> +  exit(EXIT_FAILURE);
> +}

Maybe this function could be improved by adding perror() call
if errno != 0? Now user would see
SYMIFY ERROR: read error
and it doesn't help much to determine what exactly went wrong.

Laurynas

- Raw text -