Date:	Tue, 15 Aug 2000 08:59:50 +0200
From:	"Eli Zaretskii" <eliz AT is DOT elta DOT co DOT il>
Sender:	halo1 AT zahav DOT net DOT il
To:	lauras AT softhome DOT net
Message-Id:	<9743-Tue15Aug2000085950+0300-eliz@is.elta.co.il>
X-Mailer:	Emacs 20.6 (via feedmail 8.2.emacs20_6 I) and Blat ver 1.8.5b
CC:	djgpp-workers AT delorie DOT com
In-reply-to:	<399844B1.9A99D08F@softhome.net> (message from Laurynas Biveinis
	on Mon, 14 Aug 2000 21:12:49 +0200)
Subject:	Re: Patch: lstat() adjustments for symlinks
References:	<399844B1 DOT 9A99D08F AT softhome DOT net>
Reply-To:	djgpp-workers AT delorie DOT com
Errors-To:	nobody AT delorie DOT com
X-Mailing-List:	djgpp-workers AT delorie DOT com
X-Unsubscribes-To:	listserv AT delorie DOT com

> Date: Mon, 14 Aug 2000 21:12:49 +0200
> From: Laurynas Biveinis <lauras AT softhome DOT net>
> 
> It adds new macros S_ISLNK and S_IFLNK, as well as code to set them
> in lstat() and testsuite.

Thanks!

> Any comments?

One minor one, about the doco:

> +@findex S_IFLNK AT r{, and symlink support}
> +@findex S_IFLNK AT r{, added to the library}

There's something I learned a long time ago from Richard Stallman: It
is not very useful to have more than a single index entry which all
begin with the same substring and all point to the same place (or to
very close places).  They are redundant: a person who uses the index
lookup commands will find the place if only one of these index entries
is left.

One more nit:

> Index: djgpp/tests/libc/posix/sys/stat/lstat.c
[snip]
> +   printf("Test 2 passed\n");
> +   remove(tmp_file);
> +   return 0;
> +}
> \ No newline at end of file

Unless you have a good reason for this lack of a newline, please add
one.  I'm afraid some brain-dead editors will barf on such files, or
did some weird things with the last line.

- Raw text -