Mailing-List:	contact cygwin-apps-help AT cygwin DOT com; run by ezmlm
Sender:	cygwin-apps-owner AT cygwin DOT com
List-Subscribe:	<mailto:cygwin-apps-subscribe AT cygwin DOT com>
List-Archive:	<http://sources.redhat.com/ml/cygwin-apps/>
List-Post:	<mailto:cygwin-apps AT cygwin DOT com>
List-Help:	<mailto:cygwin-apps-help AT cygwin DOT com>, <http://sources.redhat.com/lists.html#faqs>
Mail-Followup-To:	cygwin-apps AT cygwin DOT com
Delivered-To:	mailing list cygwin-apps AT cygwin DOT com
From:	"Ralf Habacker" <Ralf DOT Habacker AT freenet DOT de>
To:	"Cygwin-Apps" <cygwin-apps AT cygwin DOT com>,
	"Binutils" <binutils AT sources DOT redhat DOT com>
Cc:	"LaurentPinchart" <laurent DOT pinchart AT skynet DOT be>
Subject:	RE: binutils status ?
Date:	Tue, 21 May 2002 22:11:42 +0200
Message-ID:	<000501c20103$b942fd20$905f07d5@BRAMSCHE>
MIME-Version:	1.0
X-Priority:	3 (Normal)
X-MSMail-Priority:	Normal
X-MimeOLE:	Produced By Microsoft MimeOLE V5.50.4133.2400
Importance:	Normal
In-Reply-To:	<006c01c2009b$201f2c80$b96407d5@BRAMSCHE>

> > 3) Ralf's patch for "objdump/cygwin crashes on auto-imported libs"
> >
> > Nick Clifton has applied a patch for a similar problem, I will look if this
> > solve this already.
> >
I was wrong, it was Laurent Pinchart, who has applied this patch.

> This patch does not help in this case. I will inspect this and supply
> a updated
> patch.
>
In peXXigen.c Line 1208 there is a case handling rebinded imports, which isn't
affected by Laurent's Patch.

	      /* If the time stamp is not zero, the import address
                 table holds actual addresses.  */
	      if (time_stamp != 0
		  && first_thunk != 0
		  && first_thunk != hint_addr)
		fprintf (file, "\t%04lx",
(1)			 (long) bfd_get_32 (abfd, data + first_thunk - adj + j));
                                               ^^^^^^^^^^^^^^
this fails in case of rebinded apps or dll, that means first_thunk points into
the text segment
this printing should goes after laurent patch, when the different section is
loaded

	      fprintf (file, "\n");
	    }
	}

--- here starts Laurant's patch ---

      if (hint_addr != first_thunk && time_stamp == 0)
	{
          bfd_byte *ft_data;
	  asection *ft_section;
<snip>

Laurant: Can you give a hint how the line marked with (1) should be changed ?

Ralf

- Raw text -