DMARC-Filter:	OpenDMARC Filter v1.4.2 delorie.com 64I157c74124417
Authentication-Results:	delorie.com; dmarc=pass (p=none dis=none) header.from=cygwin.com
Authentication-Results:	delorie.com; spf=pass smtp.mailfrom=cygwin.com
DKIM-Filter:	OpenDKIM Filter v2.11.0 delorie.com 64I157c74124417
Authentication-Results:	delorie.com;
	dkim=pass (1024-bit key, unprotected) header.d=cygwin.com header.i=@cygwin.com header.a=rsa-sha256 header.s=default header.b=Pu9iITMc
X-Recipient:	archive-cygwin AT delorie DOT com
DKIM-Filter:	OpenDKIM Filter v2.11.0 sourceware.org 55F274BA9006
DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1779066304;
	bh=ze6Yv/4iiUnYsQINI1KgsWq3y8sVMMq2Cd9X1w/9o6s=;
	h=Date:To:Subject:In-Reply-To:References:List-Id:List-Unsubscribe:
	List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:
	From;
	b=Pu9iITMcOMreEuv3cffCJAWFTXl1FXDUx75TuSE2eRiIz12FWJoeAUKGmSHlDWY+T
	OfgHiEhTiOvIY2veHFYAGsrXnn6Vvhsgupdt2dBOcbDAlsH9a0eN3A23l4R+UDdxM8
	S9qlIGftyMUYLheUneOE4e0jPmeClH9IHlMhsg3M=
X-Original-To:	cygwin AT cygwin DOT com
Delivered-To:	cygwin AT cygwin DOT com
DMARC-Filter:	OpenDMARC Filter v1.4.2 sourceware.org 878534BA79A7
ARC-Filter:	OpenARC Filter v1.0.0 sourceware.org 878534BA79A7
ARC-Seal:	i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779066250; cv=none;
	b=wdGO3W9l2trcVOMzCTleKRYlrwFDCxEHIwHD7NEMmxcv4vOjfP5/2WdAYqRoVI5u+87zcRbMP+k1ee/Cogjx8I3w244EHHa9hawvcNfvbA7ZRMn5TRND+cemR4t1nJo27ceUr7ac7VRik2ybtVuvmUeIyKtwWPji32+OfOMX8e4=
ARC-Message-Signature:	i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1779066250; c=relaxed/simple;
	bh=zO60/Xw51ZF6s4FgDr6NOYeVY6GN6N9aDLINm+a57KM=;
	h=Date:From:To:Subject:Message-Id:Mime-Version:DKIM-Signature;
	b=PFsGl84sa+kGZiYSX5J+fhFcc21027bdfnTx8s0LUgcNEhDn+oa35YN/CodMAjHy/+H6ohiuw105vsynXUdBp5/u+hiyoZT1FqE2LtIsSaIJYz8sGPpGbMPG7STw/+6r0UNBmrA9aHNVERjcHLNq/V+KtlkTJBM+Vd3Lv/NJj30=
ARC-Authentication-Results:	i=1; sourceware.org;
	dkim=pass (2048-bit key, unprotected)
	header.d=nifty.ne.jp header.i=@nifty.ne.jp header.a=rsa-sha256
	header.s=default-1th84yt82rvi header.b=JCKRpNrd
DKIM-Filter:	OpenDKIM Filter v2.11.0 sourceware.org 878534BA79A7
Date:	Mon, 18 May 2026 10:04:04 +0900
To:	cygwin AT cygwin DOT com
Subject:	Re: On exit, winsup/cygwin/fhandler/console.cc waits on closed
	handle, deadlock possible
Message-Id:	<20260518100404.fa8ecf8901503c72bb610ece@nifty.ne.jp>
In-Reply-To:	<20260514231148.60c1743e@Tarkus>
References:	<20260513125959 DOT 52327763 AT arachnoid>
	<20260514231148 DOT 60c1743e AT Tarkus>
X-Mailer:	Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32)
Mime-Version:	1.0
X-BeenThere:	cygwin AT cygwin DOT com
X-Mailman-Version:	2.1.30
List-Id:	General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe:	<https://cygwin.com/mailman/options/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive:	<https://cygwin.com/pipermail/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe:	<https://cygwin.com/mailman/listinfo/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From:	Takashi Yano via Cygwin <cygwin AT cygwin DOT com>
Reply-To:	Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp>
Errors-To:	cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com
Sender:	"Cygwin" <cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com>

On Thu, 14 May 2026 23:11:48 +0300
Ivan Krylov wrote:
> On Wed, 13 May 2026 12:59:59 +0300
> Ivan Krylov <ikrylov AT disroot DOT org> wrote:
> 
> > I think it doesn't close the race window completely.
> 
> Here's a patch that I have more confidence in:
> 
> diff --git a/winsup/cygwin/fhandler/console.cc b/winsup/cygwin/fhandler/console.cc
> index c76347f6f..a97df4cef 100644
> --- a/winsup/cygwin/fhandler/console.cc
> +++ b/winsup/cygwin/fhandler/console.cc
> @@ -62,6 +62,7 @@ fhandler_console::console_state NO_COPY
>  
>  static bool NO_COPY inside_pcon_checked = false;
>  static bool NO_COPY inside_pcon = false;
> +static LONG NO_COPY inside_pcon_cleanup = 0;
>  static int NO_COPY parent_pty;
>  static HANDLE NO_COPY parent_pty_input_mutex = NULL;
>  
> @@ -530,8 +531,13 @@ fhandler_console::cons_master_thread (handle_set_t *p, tty *ttyp)
>  	default: /* Error */
>  	  free (input_rec);
>  	  free (input_tmp);
> -	  if (inside_pcon && parent_pty_input_mutex)
> +	  if (inside_pcon && parent_pty_input_mutex) {
>  	    ReleaseMutex (parent_pty_input_mutex);
> +	    if (InterlockedCompareExchange(&inside_pcon_cleanup, 0, 0)) {
> +	      ForceCloseHandle (parent_pty_input_mutex);
> +	      inside_pcon = false;
> +	    }
> +	  }
>  	  ReleaseMutex (p->input_mutex);
>  	  return;
>  	}
> @@ -713,8 +719,13 @@ remove_record:
>  	  while (true);
>  	}
>  skip_writeback:
> -      if (inside_pcon && parent_pty_input_mutex)
> +      if (inside_pcon && parent_pty_input_mutex) {
>  	ReleaseMutex (parent_pty_input_mutex);
> +	if (InterlockedCompareExchange(&inside_pcon_cleanup, 0, 0)) {
> +	  ForceCloseHandle (parent_pty_input_mutex);
> +	  inside_pcon = false;
> +	}
> +      }
>        ReleaseMutex (p->input_mutex);
>        cygwait (40);
>      }
> @@ -2048,7 +2059,7 @@ fhandler_console::pcon_hand_over_proc (void)
>    else
>      system_printf("Acquiring pcon_ho_mutex failed.");
>    ReleaseMutex (mtx);
> -  ForceCloseHandle (parent_pty_input_mutex);
> +  InterlockedExchange(&inside_pcon_cleanup, 1);
>  }
>  
>  bool
> 
> Instead of manipulating the mutex handle shared between threads and
> leaving a race window between if(parent_pty_input_mutex) and
> WaitForSingleObject(parent_pty_input_mutex, ...), tell the
> cons_master_thread to close the handle and stop using it.

Thanks for the report and the patch.

The root cause of the problem is closing parent_pty_input_mutex before
stopping cons_master_thread.

What abount just moving
> -  ForceCloseHandle (parent_pty_input_mutex);
into fhandler_console::close() like:

diff --git a/winsup/cygwin/fhandler/console.cc b/winsup/cygwin/fhandler/console.cc
index c76347f6f..c4950885a 100644
--- a/winsup/cygwin/fhandler/console.cc
+++ b/winsup/cygwin/fhandler/console.cc
@@ -2048,7 +2048,6 @@ fhandler_console::pcon_hand_over_proc (void)
   else
     system_printf("Acquiring pcon_ho_mutex failed.");
   ReleaseMutex (mtx);
-  ForceCloseHandle (parent_pty_input_mutex);
 }
 
 bool
@@ -2157,6 +2156,9 @@ fhandler_console::close (int flag)
   CloseHandle (output_mutex);
   output_mutex = NULL;
 
+  ForceCloseHandle (parent_pty_input_mutex);
+  parent_pty_input_mutex = NULL;
+
   WaitForSingleObject (shared_info_mutex, INFINITE);
   if (--shared_info_state[unit] == 0 && shared_console_info[unit])
     {

-- 
Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp>

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

- Raw text -