DMARC-Filter:	OpenDMARC Filter v1.4.2 delorie.com 61EJgd1o902597
Authentication-Results:	delorie.com; dmarc=pass (p=none dis=none) header.from=cygwin.com
Authentication-Results:	delorie.com; spf=pass smtp.mailfrom=cygwin.com
DKIM-Filter:	OpenDKIM Filter v2.11.0 delorie.com 61EJgd1o902597
Authentication-Results:	delorie.com;
	dkim=pass (1024-bit key, unprotected) header.d=cygwin.com header.i=@cygwin.com header.a=rsa-sha256 header.s=default header.b=WnJADv2/
X-Recipient:	archive-cygwin AT delorie DOT com
DKIM-Filter:	OpenDKIM Filter v2.11.0 sourceware.org C9CE14BAD177
DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1771098157;
	bh=Kl71LcQ2EGO3ZV+Cg9AUbi+mEMaw+qIvZZBOTLfOeHc=;
	h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post:
	List-Help:List-Subscribe:From:Reply-To:From;
	b=WnJADv2/4sXpMZlIPtvVyn99pgnssIYj+CHHkN4ysO05pSAXlZncWK/68MHz3UnG5
	GCbhA3CAvYc3mxzeQ4QK+nEkN7X9PPSF+scLyygJutqhYIKYGE2iaEELkuWCIJ0fsQ
	bVIW1GeiGK+X9IX0BmuG+F2zRL0BgaUfro4lBVaA=
X-Original-To:	cygwin AT cygwin DOT com
Delivered-To:	cygwin AT cygwin DOT com
DMARC-Filter:	OpenDMARC Filter v1.4.2 sourceware.org 2BBA14BAD151
ARC-Filter:	OpenARC Filter v1.0.0 sourceware.org 2BBA14BAD151
ARC-Seal:	i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1771098109; cv=pass;
	b=TgklKpdgufLN88AS+HyuyJFpkz+Aa1VY9ocfQAsm1Gq2OwRcFevhuNV+7D6B4qNhcbn0hO6bfLxxO/8soyskZTqmzo/WIk1+e7zah4OikpVIrEKLn1F4w5xb/AuslfwOmbk1rZpe3TIPa7mM81nfJ22iCgGOGXJC1XMyddaSyKA=
ARC-Message-Signature:	i=2; a=rsa-sha256; d=sourceware.org; s=key;
	t=1771098109; c=relaxed/simple;
	bh=qURG8gxDIudX37nv0zFsMbimwpbPIe6QkzLD/nvDR5o=;
	h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To;
	b=ZPjTQFXZvQ7mgsehmboaNXtNIUNSlGcZxQEqIJPc3kOl/vG0/qpIUwcDaNHpR99PubtsfMBInXJ2t1+clkV1O+9VGlV5OIEkgcGV/ymy6jvKgIX3tyIz3VwcXdjqqADm2m0LCZTBh+TYd6FBLRIiVg6Y7qa+LvNfG6loCMwuJwM=
ARC-Authentication-Results:	i=2; server2.sourceware.org
DKIM-Filter:	OpenDKIM Filter v2.11.0 sourceware.org 2BBA14BAD151
ARC-Seal:	i=1; a=rsa-sha256; t=1771098108; cv=none;
	d=google.com; s=arc-20240605;
	b=CKCrw2IOvCtG8368VJFPyXhEpOm+titk0UjnXpaZVowAS6Bn79QAnuBKZ2Iwp0efBD
	8BKXdy5d5LAesa6U/+7Z1zJbBeTpZU7H5VLzR1SnoGj9IUhEN90w2RBX/QxUEsnJyFw/
	J0ibPArfh6hFKpRdFqQs4hyvOVoNAiHMt4hCL24g9kKVp8iSf2y8nGwr3lzKHYaObPp4
	umuLmaywUYXKD7I5onEF7iCGZBhl84i78X7DZAs+aq/wMp2s8hB2wrR+ZbQptr/6hoXd
	66Hyw3y0ytEBrvbkdB7nF7lOSLwxu85Tg8JlRq+ivlYkC7sp9Ima8xpT5ssiuBx5dqyR
	kqOw==
ARC-Message-Signature:	i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
	s=arc-20240605;
	h=content-transfer-encoding:to:subject:message-id:date:from
	:mime-version:dkim-signature;
	bh=6Mv+koKYyX+KUMhaR3RlOeGdI6E8QKlIL/kuVBGwnA0=;
	fh=YZH5uM5/yfouasGmhd4aBgFJjkmPDWmx6Ke4uaPtCZY=;
	b=SQl/MFaax3K1XwqcZ+pXPYsSgN1XYxhhK1CohoI7V/BzVh8nWxipHEwO6Y3wogzOai
	m5U000gSIXJ3SEA8VSsL4aeptuv3rh64pR/utEmC6RgVSA+b2z80Yu++25OQmqtL+Z7s
	f0RaOKIXvLC1Nd/UEkz8iy3C0y6Bi8BGkJWQFoV6BEfIPWosaasQG6Rp6UDwLDuYDnEo
	2Hq/ljUf4aZ6+aqv5Ktr3PTIJ58Z6BELMxHo8iJ9DFmIAr7kxh4Fn2y/1SA9SFI0L0kn
	dNDMIOQL1Ca6YXbK7nRwj0okKhpSpvDWkTKvvLUda1O3fnshNi+Vm6VH9oA/h8BFDxAq
	73EQ==; darn=cygwin.com
ARC-Authentication-Results:	i=1; mx.google.com; arc=none
X-Google-DKIM-Signature:	v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20230601; t=1771098108; x=1771702908;
	h=content-transfer-encoding:to:subject:message-id:date:from
	:mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date
	:message-id:reply-to;
	bh=6Mv+koKYyX+KUMhaR3RlOeGdI6E8QKlIL/kuVBGwnA0=;
	b=qOg0HvqzIRADGby1aPhaiatMS3sjCUvxVHQOfeHbKUHAxevBb8S4XThFmfmjVJZ1Yh
	bGnG822gI+Cni/tRUAcpw3T+EYiQLYzgGOHrpPX3fL56OT+Cja26N2LcuEeIJErGt3S2
	Ddk6Nydcldx0SVz9OQ4/GNxBnXTTWaNl9L0Pa3f1XWCSW8ZJ3UHyY5WN9VgSVd97HP59
	AMjjjygJtOb0wtRIQUzLCdiT7mfP/3CPukola6myelHHXtqWlMciNDZFAYva0mzaNBvs
	AQ0g+CzxitfIogTqOF3mJD7fKvmQK/RFhwWdq9coQ4O/+MkLyPPISeJHRAMNy5MaicuP
	kiTw==
X-Gm-Message-State:	AOJu0YwMrzbQiOYdD3lv1hUjv66nJ2dQqCviJ4ZsgRPP2HoMVH5o24lV
	uPlFtmxfQxwNulE5tXu5ZU8gBivWRzWuubPmw9qI+uSAOiyd0l7sdv/hHsvC56J/smGcz95+eVx
	Xkzz544TsvORNrN1JDQX64pxc0OQqLpG8seQ6
X-Gm-Gg:	AZuq6aJ6o361l0yM63dg4QYeNK559ifOkmQSiOD28fCtrXGVDjHAwf0bNmyZad/6ut8
	ZizWTFK8Fvnv802Ljaxo1FJ+78qQ0hTh1DpzCT7kLLMBzLKLIVTwiGoQX6JwMHchucMXxTZJ5s9
	81nSz7P+i94Xl4oVXdcqKl+KEpF/CKYmUs45szCd1RhoFhPf1T+xXEF1gA8iCN3+ZLJAy8FAOkn
	3uTJ1IIWJ48G3r3gtzqf9smdi19XlQGBMC98SsoNxMHvI46sQHiBOrD9XMbV+f8Un5s9FVDSmHd
	SgEBdMjQfmamk7earDDuAYvxXAISzX38d0DOPxQSY1S1JTsMQAyMU7HO1dJ1zxa/9Hf4
X-Received:	by 2002:a05:600c:6206:b0:477:76c2:49c9 with SMTP id
	5b1f17b1804b1-48373a0842fmr88493645e9.2.1771098107944; Sat, 14 Feb 2026
	11:41:47 -0800 (PST)
MIME-Version:	1.0
Date:	Sat, 14 Feb 2026 20:41:37 +0100
X-Gm-Features:	AaiRm51mRx6-TkVlgksAc9I0dG8qTqpE4bn6i4kvWlsHvNunKKJq70GN-7Zo11I
Message-ID:	<CADt9575bV4TS0AAzcfDP=W1WgqUKEoDpLHUFQjx+5twuyzPdWw@mail.gmail.com>
Subject:	BUG: "machine/types.h" not protected by multiple #include
To:	The Cygwin Mailing List <cygwin AT cygwin DOT com>
X-BeenThere:	cygwin AT cygwin DOT com
X-Mailman-Version:	2.1.30
List-Id:	General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Archive:	<https://cygwin.com/pipermail/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe:	<https://cygwin.com/mailman/listinfo/cygwin>,
	<mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From:	"Carlo B. via Cygwin" <cygwin AT cygwin DOT com>
Reply-To:	"Carlo B." <carlo DOT bramini AT gmail DOT com>
Sender:	"Cygwin" <cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com>
X-MIME-Autoconverted:	from base64 to 8bit by delorie.com id 61EJgd1o902597

Hello,
while compiling libsrtp2, I got this error:

/usr/include/machine/types.h:35:8: error: redefinition of ‘struct flock’
   35 | struct flock {
      |        ^~~~~
In file included from /usr/include/sys/types.h:222,
                 from
../gstreamer/subprojects/libsrtp-2.7.0/crypto/include/integers.h:60:
/usr/include/machine/types.h:35:8: note: originally defined here
   35 | struct flock {
      |        ^~~~~

This happens because into the library there is this code:

<--- CUT --->
#ifdef HAVE_SYS_TYPES_H
#include <sys/types.h>
#endif
#ifdef HAVE_MACHINE_TYPES_H
#include <machine/types.h>
#endif
<--- CUT --->

The first inclusion of "sys/types.h" includes also "machine/types.h"
and this is ok.
Next, the second directive includes again "machine/types.h" and here
it generates the error.
The problem comes out because "machine/types.h" has not a protection
against multiple inclusions. Actually, something like that should be
done on top and on the bottom of "machine/types.h", like I have seen
elsewhere on other libc:

#ifndef    _MACHTYPES_H_
#define    _MACHTYPES_H_
....
#endif /* _MACHTYPES_H_ */

By doing this change, everything will work properly because
"machine/types.h" won't try to declare again its types if it has been
already included. I don't know why libsrtp2 is doing this, perhaps it
is needed by other platforms.
However, I think that it should be quite easy to add this change and
make things more safe.

Sincerely,

Carlo Bramini.

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

- Raw text -