www.delorie.com/archives/browse.cgi | search |
X-Recipient: | archive-cygwin AT delorie DOT com |
DomainKey-Signature: | a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id |
:list-unsubscribe:list-subscribe:list-archive:list-post | |
:list-help:sender:subject:to:references:from:message-id:date | |
:mime-version:in-reply-to:content-type; q=dns; s=default; b=ZY0g | |
q6BaWIukExjGuiJ+a2bZKx8DUilHj72gz+47hRSyJxuNt50Ut2SlmnLkhAtnbTww | |
Yab636OWGME60i/Q+nI3O6Li4yn8xcVH2/ZjlNGAk/8K1eTJbvakl/IdjKajVq1B | |
43etIeZDknMsAtW+tUKyJFHLVlJC0oMupRpoiBg= | |
DKIM-Signature: | v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id |
:list-unsubscribe:list-subscribe:list-archive:list-post | |
:list-help:sender:subject:to:references:from:message-id:date | |
:mime-version:in-reply-to:content-type; s=default; bh=XQZeOmSJqX | |
gK2v1SCffZ1bIEE48=; b=Ee0L6Gqq2hDuKUIipKuevZLf5KdBcbD3AgtSI04975 | |
JNHiZ4W1yjISFPhsPI5/e67LZ3Rgwta/RU0o0gHTrmRGyLLPVGzPQkWO5sYzzPVc | |
94pdFKkLbg7mQ9SHVjoChJWKLafT7aE76WG8ATKyP1h79e3PEu4qUImy8djjiLPF | |
8= | |
Mailing-List: | contact cygwin-help AT cygwin DOT com; run by ezmlm |
List-Id: | <cygwin.cygwin.com> |
List-Subscribe: | <mailto:cygwin-subscribe AT cygwin DOT com> |
List-Archive: | <http://sourceware.org/ml/cygwin/> |
List-Post: | <mailto:cygwin AT cygwin DOT com> |
List-Help: | <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs> |
Sender: | cygwin-owner AT cygwin DOT com |
Mail-Followup-To: | cygwin AT cygwin DOT com |
Delivered-To: | mailing list cygwin AT cygwin DOT com |
Authentication-Results: | sourceware.org; auth=none |
X-Spam-SWARE-Status: | No, score=-10.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=iswcntrl, Haible, haible, EOF |
X-HELO: | mout.kundenserver.de |
Subject: | Re: iswcntrl() regression |
To: | cygwin AT cygwin DOT com |
References: | <24530320 DOT 43gEWRNkUz AT omega> <cd4691c0-da99-46b5-6001-594499a8d2fa AT towo DOT net> <20181219133711 DOT GJ28727 AT calimero DOT vinschen DOT de> <6550638 DOT IhVCuUnqCC AT omega> <20190106202109 DOT GD4430 AT calimero DOT vinschen DOT de> <8758e963-7f32-a3f4-4d66-ce0d0c5f831e AT towo DOT net> |
From: | Thomas Wolff <towo AT towo DOT net> |
Message-ID: | <18c44153-0e69-80f9-81c7-544009f83b8c@towo.net> |
Date: | Fri, 11 Jan 2019 02:07:45 +0100 |
User-Agent: | Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
MIME-Version: | 1.0 |
In-Reply-To: | <8758e963-7f32-a3f4-4d66-ce0d0c5f831e@towo.net> |
X-IsSubscribed: | yes |
--------------614599C208658FE7244A5A26 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Am 06.01.2019 um 23:39 schrieb Thomas Wolff: > Am 06.01.2019 um 21:21 schrieb Corinna Vinschen: >> On Dec 19 21:57, Bruno Haible wrote: >>> Hello Thomas, >>> >>> Oops 1: I forgot to add the reference to POSIX: >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswcntrl.html >>> >>> Oops 2: >>> The relevant expression is iswcntrl (WEOF), not iswcntrl (EOF). >>> >>>>> Are there any other special requirements concerning EOF? >>> WEOF is a special value. The difference between wint_t and wchar_t is >>> essentially that WEOF fits into wint_t but is not guaranteed to fit >>> in wchar_t. >>> (Like EOF fits into 'int' but usually does not fit in 'unsigned char'.) >>> >>> WEOF is special for all functions declared in <wctype.h>, see >>> >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswalnum.html >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswalpha.html >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswblank.html >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswcntrl.html >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswdigit.html >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswgraph.html >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswlower.html >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswprint.html >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswpunct.html >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswspace.html >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswupper.html >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswxdigit.html >>> >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/iswctype.html >>> >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/towlower.html >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/towupper.html >>> http://pubs.opengroup.org/onlinepubs/9699919799/functions/towctrans.html >>> >>> >>>> this could be fixed in iswcntrl_l.c as a special condition, or >>>> injected as a special case in the categories.t table. >>> Probably, yes. >> Thomas, any input? Are you going to provide patches? > Well, yes, now I'm assuming that this is the only WEOF special case > and I'll look after it this week. > Thomas The fix should be as attached. However, I don't seem to be able to produce a git format patch; when I `git format-patch -1` (after `git pull` and modifying only the affected file) it produces a patch file Subject: [PATCH] Cygwin: try_to_bin: don't check recycler filename all the time ... Signed-off-by: Corinna Vinschen <corinna AT vinschen DOT de> ---  winsup/cygwin/syscalls.cc | 71 +++++++++++++++++++++------------------ ... which is weird. Thomas --------------614599C208658FE7244A5A26 Content-Type: text/plain; charset=UTF-8; name="0001-iswcntrl-WEOF.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-iswcntrl-WEOF.patch" LS0tIG5ld2xpYi9saWJjL2N0eXBlL2NhdGVnb3JpZXMuY34JMjAxOC0wOC0x OCAwOTo1MDoxNi4zOTc5OTcxMDAgKzAyMDAKKysrIG5ld2xpYi9saWJjL2N0 eXBlL2NhdGVnb3JpZXMuYwkyMDE5LTAxLTExIDAxOjU2OjM5LjE1NTczNjcw MCArMDEwMApAQCAtMTksNyArMTksNyBAQCBiaXNlYXJjaF9jYXQod2ludF90 IHVjcywgY29uc3Qgc3RydWN0IF9jCiAgIGludCBtaWQ7CiAKICAgaWYgKHVj cyA8IHRhYmxlWzBdLmZpcnN0IHx8IHVjcyA+IHRhYmxlW21heF0uZmlyc3Qg KyB0YWJsZVttYXhdLmRlbHRhKQotICAgIHJldHVybiAwOworICAgIHJldHVy biAtMTsKICAgd2hpbGUgKG1heCA+PSBtaW4pCiAgICAgewogICAgICAgbWlk ID0gKG1pbiArIG1heCkgLyAyOwo= --------------614599C208658FE7244A5A26 Content-Type: text/plain; charset=us-ascii -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple --------------614599C208658FE7244A5A26--
webmaster | delorie software privacy |
Copyright © 2019 by DJ Delorie | Updated Jul 2019 |