X-Recipient:	archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status:	No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS
X-Spam-Check-By:	sourceware.org
Message-ID:	<4A8D396D.8000209@gmail.com>
Date:	Thu, 20 Aug 2009 12:54:21 +0100
From:	Dave Korn <dave DOT korn DOT cygwin AT googlemail DOT com>
User-Agent:	Thunderbird 2.0.0.17 (Windows/20080914)
MIME-Version:	1.0
To:	cygwin AT cygwin DOT com
Subject:	Re: find(1) memory leak in cygheap
References:	<c8a3efee0908190447l11062bf1waba8ca9df5581468 AT mail DOT gmail DOT com> <20090819140322 DOT GB8713 AT ednor DOT casa DOT cgf DOT cx> <c8a3efee0908190804i4130ecbfp7561934ab2272da8 AT mail DOT gmail DOT com> <c8a3efee0908192309k4e207b4fs662d2c2baae8c0a2 AT mail DOT gmail DOT com> <20090820083926 DOT GJ32408 AT calimero DOT vinschen DOT de> <c8a3efee0908200323v6ffc605cuc74b45533bf99048 AT mail DOT gmail DOT com>
In-Reply-To:	<c8a3efee0908200323v6ffc605cuc74b45533bf99048@mail.gmail.com>
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com

Haojun Bao wrote:

> 215  path_conv &operator =(path_conv& pc)
> 216  {
> 217    memcpy (this, &pc, sizeof pc);

  Ow yuck!  I very much hope nobody ever creates derived classes of path_conv
that introduce virtual functions into the base class, or we're going to have a
very tricky to find bug here.  (Hmm, now there's an idea.  GCC needs an
__attribute__ that you can tag onto a class to say it must be a POD-type and
get a compiler error if anyone ever adds a virtual function or anything else
that would make the layout non-POD.)

    cheers,
      DaveK


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

- Raw text -