X-Recipient:	archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status:	No, hits=-3.2 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_52,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By:	sourceware.org
To:	cygwin AT cygwin DOT com
From:	Eric Blake <ebb9 AT byu DOT net>
Subject:	Re: csih: Patch getVolInfo.c
Date:	Wed, 22 Jul 2009 19:54:58 +0000 (UTC)
Lines:	26
Message-ID:	<loom.20090722T195138-214@post.gmane.org>
References:	<20090722185402 DOT GS27613 AT calimero DOT vinschen DOT de> <20090722192657 DOT GU27613 AT calimero DOT vinschen DOT de>
Mime-Version:	1.0
User-Agent:	Loom/3.14 (http://gmane.org/)
X-IsSubscribed:	yes
Mailing-List:	contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id:	<cygwin.cygwin.com>
List-Subscribe:	<mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive:	<http://sourceware.org/ml/cygwin/>
List-Post:	<mailto:cygwin AT cygwin DOT com>
List-Help:	<mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender:	cygwin-owner AT cygwin DOT com
Mail-Followup-To:	cygwin AT cygwin DOT com
Delivered-To:	mailing list cygwin AT cygwin DOT com

Corinna Vinschen <corinna-cygwin <at> cygwin.com> writes:

> > However, for access to the filesystem information, the READ_CONTROL
> > isn't necessary.  A desired access of 0 is sufficient in every case
> > I could lay my hands on (NTFS, NFS, Samba, FAT32, HGFS).
> > 
> along these lines, can you please test the change to mount.cc on MVFS?

Seeing as how you aren't in a position to lay your hands on MVFS, I get to be 
the bearer of bad news.

You'll have to recode this to do a retry loop, since MVFS rejects NtOpenFile 
with access of 0, giving status 0xc0000022.  The only question now is whether 
you should do the READ_CONTROL first and retry to 0, or 0 first and 
READ_CONTROL as the retry.

> It would be a pity if MVFS would be broken again due to this change,
> after having gone through all the hassle of the last days.

And of course, with 'df -T mvfs/file' now showing "unknown" instead of "mvfs", 
you can imagine what else broke.

-- 
Eric Blake




--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

- Raw text -