www.delorie.com/archives/browse.cgi   search  
Mail Archives: cygwin/2000/11/09/23:39:20

Mailing-List: contact cygwin-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin/>
List-Post: <mailto:cygwin AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin AT sources DOT redhat DOT com
Date: Thu, 9 Nov 2000 23:38:38 -0500
From: Christopher Faylor <cgf AT redhat DOT com>
To: "'cygwin AT sources DOT redhat DOT com'" <cygwin AT sources DOT redhat DOT com>
Subject: Re: Case-insensitive globbing (was RE: Cygnus question)
Message-ID: <20001109233838.C6759@redhat.com>
Reply-To: cygwin AT sources DOT redhat DOT com
Mail-Followup-To: "'cygwin AT sources DOT redhat DOT com'" <cygwin AT sources DOT redhat DOT com>
References: <F10D23B02E54D011A0AB0020AF9CEFE988F9C3 AT lynx DOT ceddec DOT com>
Mime-Version: 1.0
User-Agent: Mutt/1.3.6i
In-Reply-To: <F10D23B02E54D011A0AB0020AF9CEFE988F9C3@lynx.ceddec.com>; from btown@ceddec.com on Thu, Nov 09, 2000 at 11:09:16AM -0500

On Thu, Nov 09, 2000 at 11:09:16AM -0500, Town, Brad wrote:
>> The problem is that the glob() function is exported from the 
>> DLL.  I don't
>> know if its operation should be under the control of the 
>> CYGWIN environment
>> variable when it is called by the program directly.  I don't 
>> think it should
>> be actually.
>
>I agree.  I've made the change and attached new patches.
>
>> I'd appreciate it if you would test that glob's operation 
>> when called from
>> a program is unchanged, too.
>
>Source to the program I used to test is attached.
>
>So, for those of you just joining us, adding "glob" to the CYGWIN
>environment variable enables case-sensitive globbing for arguments passed on
>the command line when the program is called from a Windows shell.  With the
>patches, "glob:ignorecase" would make the globbing case-insensitive.

Looks good with a couple of minor issues (sorry).

The changes to reset the globbing case sensitivity should go right
before the call to main in dcrt0.cc.  In 1.1.5 the code which breaks apart
argv is not called for cygwin subprocesses so resetting ignore_case_glob
in build_argv is not a good idea.

So, if you could make that change and supply a ChangeLog entry for your
masterpiece, I'll incorporate it.  Also please include a statement telling
me that this is your work and that your employer has no claim to it.

Also, my preferences is to see diffs in '-u -p' format.  The '-p', in
particular, helps me understand what's going on a little more quickly.

I appreciate your efforts in doing this.  I think that this option will
make a lot of people happy.

cgf

--
Want to unsubscribe from this list?
Send a message to cygwin-unsubscribe AT sourceware DOT cygnus DOT com

- Raw text -


  webmaster     delorie software   privacy  
  Copyright © 2019   by DJ Delorie     Updated Jul 2019