X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
Date: Tue, 15 Aug 2017 04:51:25 +0200 (CEST)
X-X-Sender: igor2 AT igor2priv
To: "Peter Clifton (petercjclifton AT googlemail DOT com) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
X-Debug: to=geda-user AT delorie DOT com from="gedau AT igor2 DOT repo DOT hu"
From: gedau AT igor2 DOT repo DOT hu
Subject: Re: [geda-user] [pcb] mainline: redundant attributes: bug or
 feature?
In-Reply-To: <alpine.DEB.2.00.1708141129590.27212@igor2priv>
Message-ID: <alpine.DEB.2.00.1708150445190.27212@igor2priv>
References: <alpine DOT DEB DOT 2 DOT 00 DOT 1708140646240 DOT 27212 AT igor2priv> <CAJXU7q9BuoyrMLQ04sZ98NVc0rMjjUaUZ1Zb+pqn=pA3meePag AT mail DOT gmail DOT com> <alpine DOT DEB DOT 2 DOT 00 DOT 1708141129590 DOT 27212 AT igor2priv>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk



On Mon, 14 Aug 2017, gedau AT igor2 DOT repo DOT hu wrote:

> So I think it would be a reasonable behaviour to switch to unique keys and 
> throw a warning when any input (including netlist import) has redundant keys, 
> as those would be silently ignored by the code otherwise.

FYI, I did this in pcb-rnd a few minutes ago. For reference:

r10808 removes the replace argument in the attrib handling code and all 
callers, always assuming replace (to maintain unique keys)

r10809 adds the warning in the .pcb/.fp parser io_pcb

I did not find any sign that the import sch would set element attributes - 
maybe that was the plan, to import attributes from the schematics, but it 
never happened? Does the pcb netlist format even support that?

Regards,

Igor2