X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f X-Recipient: geda-user AT delorie DOT com Subject: Re: [geda-user] Notice to developers: GTS sources are gone To: geda-user AT delorie DOT com References: <55F6A91A DOT 8080402 AT jump-ing DOT de> From: "Dan McMahill (dan AT mcmahill DOT net) [via geda-user AT delorie DOT com]" Message-ID: <85e784a7-b1ab-5d1c-1eae-e0b9f77a5049@mcmahill.net> Date: Wed, 28 Dec 2016 17:48:37 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <55F6A91A.8080402@jump-ing.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfFxGk4VVBSLwzm5PifO6jKFML7JAdK6Riv4mbcKjkWbueuJwVnyrFPpCG8Ngxts6pSDSSwDGZQALYtGAt9OWghd7gGuSVoe9wFCl9r9z4++1AlyRy5S+ 7mgcavkb1jjL0Yp8niFijE8FDIXzPRY6nRn0Zoc8JCZlbtN5ricn+ooD Reply-To: geda-user AT delorie DOT com Errors-To: nobody AT delorie DOT com X-Mailing-List: geda-user AT delorie DOT com X-Unsubscribes-To: listserv AT delorie DOT com Precedence: bulk On 9/14/2015 7:01 AM, Markus Hitter (mah AT jump-ing DOT de) [via geda-user AT delorie DOT com] wrote: > > Dear developers, > > as of yesterday, sources for the GNU Triangulation Surface library (GTS) > are no longer part of gEDA/pcb sources. GTS is a well established > package, packaged for the Linux distros and easily available elsewhere. > > For developers and packagers this means: > > - Noticeable shorter compile time. > > - Additional dependency on the package. On Debian/Ubuntu the build time > dependency is "libgts-dev". Configure checks for its presence. > > - Additional runtime dependency is "libgts-0.7-5". > > - A smaller resulting package. > > - On not package based platforms you may have to build GTS first (or > disable the toporouter). > > > Cheers, > Markus > with apologies for not noticing this at the time instead of 15 months after the fact.... I object to this removal. If you read the commit log from when the sources were imported it mentions having some critical bug fixes. Since then, a few more bug fixes have been applied in the pcb tree. Unfortunately the original sources were imported *after* the initial round of bug fixes which makes it harder to see what those were. The other thing I will note is that GTS has not had an actual release in more than a decade and the bug fixes that were in the PCB source tree were more recent than that. So.... while I generally agree that we should not include 3rd party library sources in our tree, this case probably warrants putting gts back. If the concern is slow compilation time, we can disable if the topo router is disabled. If/when the fixes that the topo router depended on are submitted back upstream and gts has a release incorporating these and that release has a chance to make it into at least some of the more popular packaging systems we can revisit. However, right now, we can't count on any of the packaging systems having a gts which works correctly in pcb. This change should be reverted. Again, my apologies for being absent for the initial discussion on this. -Dan