X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
Date: Mon, 25 Jul 2016 04:15:33 +0200 (CEST)
X-X-Sender: igor2 AT igor2priv
To: "Brane2 (brane2 AT s5tehnika DOT net) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
X-Debug: to=geda-user AT delorie DOT com from="gedau AT igor2 DOT repo DOT hu"
From: gedau AT igor2 DOT repo DOT hu
Subject: Re: [geda-user] pcb: polygon "twin hole" bug - fixed
In-Reply-To: <582b39fe-fc83-7b80-8e9c-95459f5b8b1e@s5tehnika.net>
Message-ID: <alpine.DEB.2.00.1607250405550.7286@igor2priv>
References: <alpine DOT DEB DOT 2 DOT 00 DOT 1607070651120 DOT 7286 AT igor2priv> <4f9dfd62-45cd-a307-a6d9-93b7cd4333a2 AT gmail DOT com> <alpine DOT DEB DOT 2 DOT 00 DOT 1607241855150 DOT 7286 AT igor2priv> <f9211aa4-f13e-8ce6-171b-9abf3e5faab0 AT s5tehnika DOT net> <1efdee06-c218-7cac-4029-4f42e420ec82 AT s5tehnika DOT net>
 <582b39fe-fc83-7b80-8e9c-95459f5b8b1e AT s5tehnika DOT net>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk



On Mon, 25 Jul 2016, Brane2 (brane2 AT s5tehnika DOT net) [via geda-user AT delorie DOT com] wrote:

> OK. I applied it to official pcb-git and it sorts of works.

Thanks for testing this!

> I don't need separate first click for polygone selection now, but polygon 
> selection doesn't work now as advertised.
> I can draw a hole now in a polygon even if my first clicks misses all 
> polygones. Hole will stick to the polygon that I happen to nab first when 
> clicking on further hole vertexes.
> Also, If i start drawing hole over several polygons that partially cover, like 
> top and bottom layer, for some reason hole will stick to polygon on top layer, 
> even if I happen to be on the bottom layer at that time.

I first thought starting the hole out of polys was also a feature, but 
now I realize it's not. The code selects the closest polygon and assumes 
the hole is on that.

Changed this in r2309: the first click must be on a poly.

There still may be some tricky cases with overlapping polygons on the same 
layer, in which case the code still picks one of the polygons and draws 
the hole on that - the hole may then be invisible as the other polygon is 
drawn over it. However, this is not new, unpatched mainline would do the 
same.

Regards,

Igor2