X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
Date: Sun, 21 Feb 2016 09:50:44 +0100 (CET)
X-X-Sender: igor2 AT igor2priv
To: geda-user AT delorie DOT com
X-Debug: to=geda-user AT delorie DOT com from="gedau AT igor2 DOT repo DOT hu"
From: gedau AT igor2 DOT repo DOT hu
Subject: Re: [geda-user] pcb action.c bug report, ps, lpr, ./configure
 questions
In-Reply-To: <alpine.DEB.2.00.1602210747190.7885@igor2priv>
Message-ID: <alpine.DEB.2.00.1602210932380.7885@igor2priv>
References: <alpine DOT DEB DOT 2 DOT 00 DOT 1602210747190 DOT 7885 AT igor2priv>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

Hi all,

ActionPSCalib() in action.c resolves the PS exporter and calls the 
calibration function of it.

It does not check whether the exporter is present; if hid_find_exporter 
returns 0 (btw, why not NULL?), it will segfault.

Shouldn't this action rather be in src/hid/ps.c? (I moved it there in 
pcb-rnd and it works like charm.)

What should run action pscalib? I couldn't find any reference from the 
resource files or from the code. Lesstif and gtk has their separate 
PrintCalibrate() actions. May it be that the ps calib action is just dead 
code?

Slightly related: how is it possible to ./configure mainline pcb to 
compile without the ps exporter? I tried --with-exporters=bom but then lpr 
depends on ps. I tried --with-printer=none and --without-printer but both 
failed so I couldn't disable lpr.

Regards,

Igor2