X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f X-Recipient: geda-user AT delorie DOT com X-Envelope-From: paubert AT iram DOT es Date: Tue, 6 Oct 2015 15:20:05 +0200 From: "Gabriel Paubert (paubert AT iram DOT es) [via geda-user AT delorie DOT com]" To: "Markus Hitter (mah AT jump-ing DOT de) [via geda-user AT delorie DOT com]" Subject: Re: [geda-user] How to fix gerbv to compile with gcc5? Message-ID: <20151006132005.GA5039@visitor2.iram.es> References: <20151006115833 DOT GA6570 AT visitor2 DOT iram DOT es> <5613C2EC DOT 7080900 AT jump-ing DOT de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5613C2EC.7080900@jump-ing.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spamina-Bogosity: Unsure X-Spamina-Spam-Score: -1.0 (-) X-Spamina-Spam-Report: Content analysis details: (-1.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: jump-ing.de] -0.0 BAYES_40 BODY: Bayes spam probability is 20 to 40% [score: 0.3343] Reply-To: geda-user AT delorie DOT com Errors-To: nobody AT delorie DOT com X-Mailing-List: geda-user AT delorie DOT com X-Unsubscribes-To: listserv AT delorie DOT com Precedence: bulk Hi Markus, thanks for answering. I wonder who maintains patches to gerbv these days. On Tue, Oct 06, 2015 at 02:47:40PM +0200, Markus Hitter (mah AT jump-ing DOT de) [via geda-user AT delorie DOT com] wrote: > Am 06.10.2015 um 13:58 schrieb Gabriel Paubert: > > > This is a very simple patch, but you > > don't get the advantages of inlining. > > Thanks for the patch, Gabriel. AFAIK functions from other compilation > units are never inlined, unless a relatively new technology named LTO > (link time optimisation) enters the picture. > > Even then, gcc is quite good at inlining automatically, so using > 'inline' at all is pretty moot. Exception are function definitions (not > declarations) in header files, which work with 'inline', only. > > > > Anyaway here is the patch I have rigt now in my tree, disregard the "#if 0" > > for [...] > > Yes, a patch with a bit more love (tidiness) applied would be nice and > making the patch from a Git commit would also put your credentials into > the repo. No need to hide your contribution. Indeed, better patch coming. The first message was mostly a heads-up. The trouble is that I create git patches so infrequently that I always forget how to generate them. I've not yet tried to compile other packages with gcc-5.2 on my Debian testing machine. Gabriel