X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
Date: Sun, 18 Dec 2011 22:36:50 -0800
From: Andrew Poelstra <asp11 AT sfu DOT ca>
To: geda-user AT delorie DOT com
Subject: Re: [geda-user] pcb gerbers not correct
Message-ID: <20111219063650.GD30970@malakian.lan>
References: <4EDED68C DOT 90607 AT optonline DOT net>
 <20111215195020 DOT GB22563 AT malakian DOT lan>
 <1324258126 DOT 30772 DOT 1 DOT camel AT localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1324258126.30772.1.camel@localhost>
User-Agent: Mutt/1.5.20 (2009-12-10)
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

On Mon, Dec 19, 2011 at 01:28:46AM +0000, Peter Clifton wrote:
> On Thu, 2011-12-15 at 11:50 -0800, Andrew Poelstra wrote:
> 
> > I have pushed a change that (on my system, anyway) fixes this.
> > 
> > 
> > The plated drill file is printed in 1/10th mils rather than just
> > mils, so we were multiplying those values by ten before printing.
> > This is why plated-drill overflowed but nothing else did.
> > 
> > Now we just print a '0' after the values, rather than actually
> > doing the multiplication. ;)
> 
> Hmm.. your patch seems to make the hid_gerber3 test fail on my system.
> (Sorry, don't have the details of the 32/64 bit config to hand).
> 
> The following commit was the one I was about to push, but I figured it
> would be best if I asked you to review it first...
> 

> From fa9f2f8d35dfa92fda7156ebdbf90a049b5de4cc Mon Sep 17 00:00:00 2001
> From: Peter Clifton <pcjc2 AT cam DOT ac DOT uk>
> Date: Mon, 19 Dec 2011 01:24:59 +0000
> Subject: [PATCH] hid/gerber: Fixup trailing zeros from commit
>  b90fb6ae22ae83fdc0c802268dcbe74005bc705e
> 
> (The trailing zero needs to be outside the format specifier I think)?
> 

-facepalm- yes, you are right. I tested your patch on my system
(Fedora 64, 32-bit compile), and both the gerber output and the
tests look good.

I used my usual bike-stereo PCB, and a testing 500x500mm PCB,
and both worked fine.


Having said that, I see a message from Gene Glick directly
contradicting my results, so perhaps more testing is needed.


-- 
Andrew Poelstra
Email: asp11 at sfu.ca OR apoelstra at wpsoftware.net
Web:   http://www.wpsoftware.net/andrew
"I don't understand. Are you saying dualism is always good, or always bad?"