X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to;
        bh=XYDxMTL5WgTAbztCP++o2UrhfMvkU9iduUzzpJXvH4M=;
        b=Zxz6+R0QFPC6Cf/myFG8JQ5r+PMRTuez6FRolNk1cQNBBbqeUi9ZY1bI5dKwOHqF+2
         b15JAUKVEyvVu/FcSZY7LNqojxGlCIw4FmgI3eWNRil767/wqRqigdFgPJe4QMHrKRCT
         5G+LIdtkGOGk9/cDz2RsbA2NW2ASTFX7nWpL/WxlvuYVBayKEvfcncIr0Rd7bcR/JyzH
         dq9vdGhZr+h8+816KCKR4oeJhi0iMyLvk/v3Ot/yd5qFqBxzz5ALHJc4H+QsZJuq/FSU
         T8n2KU0QRH2ITV2SzXKCuO9LpopkxGvSdUHOYBn+SAdXAYcSR8XUfKBg7HqZEs0f/ZJs
         rqqw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:in-reply-to:references:from:date
         :message-id:subject:to;
        bh=XYDxMTL5WgTAbztCP++o2UrhfMvkU9iduUzzpJXvH4M=;
        b=gyPzPNZTQNDDfWA4MKUPJBWyNmUZTwQgs7keG6LSjrCPQbgPm5uimLOs8PRxOe6ZhE
         IiBqLVE1yaxQDBJmznU0e17v9hjh8NKgEcBTjB0C4LHf4QIXg7V7tUgFg9E3iu54Ym7T
         SYbhl8Apn5V5sWOyHGxIwUb598hab1hfjg8+VeBlUGZusGktHV9dbjAr7UPKu986BfDO
         SAu5ojyqSzG7/ETK417PUolYuwwZXlWJruhKxBxavNGps2Vc37JQJN0apndAav1fIvoP
         Js5KgjCCpB7Sv018DGRfbyUS2f0DumaNLDu8yanB2oS8lrXQomfLDYIIP0vN2CRIgGvb
         NvWQ==
X-Gm-Message-State: AIkVDXIMepND6KVm+OcgkHkoM3UvunH356P0pb2nAusRtR9ZNz5dDhB6I7My1VDmRA4wgB6p/9JFG6xkUi6PPw==
X-Received: by 10.28.5.193 with SMTP id 184mr58747291wmf.89.1483456071353;
 Tue, 03 Jan 2017 07:07:51 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <f1226321-a1f7-f46a-63c8-867024b13f87@mcmahill.net>
References: <f1226321-a1f7-f46a-63c8-867024b13f87 AT mcmahill DOT net>
From: "Chad Parker (parker DOT charles AT gmail DOT com) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
Date: Tue, 3 Jan 2017 10:07:50 -0500
Message-ID: <CAJZxidD=VXgSf8=HEoxRxJTFHzgo0oKzmzCBtRaG=-7r8md8Jg@mail.gmail.com>
Subject: Re: [geda-user] pcb distcheck target fails from pcb-menu.res.h
To: geda-user AT delorie DOT com
Content-Type: multipart/alternative; boundary=001a114435b82c5bfe0545320825
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

--001a114435b82c5bfe0545320825
Content-Type: text/plain; charset=UTF-8

I found that bug too while preparing the release. I thought that I pushed
it into my release branch. It's also a known bug with autotools I think,
but I didn't spend a ton of time looking into it. I added this to
POFILES.skip under the assumption that the tool will be fixed eventually:

# see https://bugs.launchpad.net/intltool/+bug/1117944
sub/src/gpcb-menu.res.h
sub/src/pcb-menu.res.h

The files aren't referenced in any of the pcb sources, only in the
Makefiles. Only the .res files are installed, not the .res.h files, so they
can't be used at runtime either. I don't see what they're used for it
anything.

--Chad


On Mon, Jan 2, 2017 at 11:20 PM, Dan McMahill (dan AT mcmahill DOT net) [via
geda-user AT delorie DOT com] <geda-user AT delorie DOT com> wrote:

> I tried to run 'make distcheck' on pcb master today and found that there
> seems to be some broken stuff in src/Makefile.am related to menu resource
> file translations.
>
> One of the things 'make distcheck' does is to verify that you can build
> from outside the source tree with a read only source tree. pcb-menu.res.h
> gets generated and then we try to copy to $srcdir (this seems broken, we
> should not be writing back to $srcdir).  That of course fails but there is
> a hack in Makefile.am to get past that.  But the later on there are
> complaints that sub/src/pcb-menu.res.h and sub/src/gpcb-menu.res.h contain
> translations but weren't listed in POTFILES.in.  This is because what is
> listed in POTFILES.in is the *source* version, not the version which was
> generated in the build tree.  Are these .res.h files actually used?  It has
> been a few years since I last dug into the menu code.
>
> Does anyone know if the menu translation stuff actually works?  Was the
> goal to have translations for the default menus?
>
>
> -Dan
>
>
>
>
>

--001a114435b82c5bfe0545320825
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">I found that bug too while preparing the release. I though=
t that I pushed it into my release branch. It&#39;s also a known bug with a=
utotools I think, but I didn&#39;t spend a ton of time looking into it. I a=
dded this to POFILES.skip under the assumption that the tool will be fixed =
eventually:<br><br># see <a href=3D"https://bugs.launchpad.net/intltool/+bu=
g/1117944">https://bugs.launchpad.net/intltool/+bug/1117944</a><br>sub/src/=
gpcb-menu.res.h<br>sub/src/pcb-menu.res.h<br><div class=3D"gmail_extra"><br=
></div><div class=3D"gmail_extra">The files aren&#39;t referenced in any of=
 the pcb sources, only in the=20
Makefiles. Only the .res files are installed, not the .res.h files, so=20
they can&#39;t be used at runtime either. I don&#39;t see what they&#39;re =
used for it anything.<br><br></div><div class=3D"gmail_extra">--Chad<br></d=
iv><div class=3D"gmail_extra"><br></div><div class=3D"gmail_extra"><br><div=
 class=3D"gmail_quote">On Mon, Jan 2, 2017 at 11:20 PM, Dan McMahill (<a hr=
ef=3D"mailto:dan AT mcmahill DOT net">dan AT mcmahill DOT net</a>) [via <a href=3D"mailto=
:geda-user AT delorie DOT com">geda-user AT delorie DOT com</a>] <span dir=3D"ltr">&lt;<a=
 target=3D"_blank" href=3D"mailto:geda-user AT delorie DOT com">geda-user AT delorie.=
com</a>&gt;</span> wrote:<br><blockquote style=3D"margin:0px 0px 0px 0.8ex;=
border-left:1px solid rgb(204,204,204);padding-left:1ex" class=3D"gmail_quo=
te">I tried to run &#39;make distcheck&#39; on pcb master today and found t=
hat there seems to be some broken stuff in src/Makefile.am related to menu =
resource file translations.<br>
<br>
One of the things &#39;make distcheck&#39; does is to verify that you can b=
uild from outside the source tree with a read only source tree. pcb-menu.re=
s.h gets generated and then we try to copy to $srcdir (this seems broken, w=
e should not be writing back to $srcdir).=C2=A0 That of course fails but th=
ere is a hack in Makefile.am to get past that.=C2=A0 But the later on there=
 are complaints that sub/src/pcb-menu.res.h and sub/src/gpcb-menu.res.h con=
tain translations but weren&#39;t listed in POTFILES.in.=C2=A0 This is beca=
use what is listed in POTFILES.in is the *source* version, not the version =
which was generated in the build tree.=C2=A0 Are these .res.h files actuall=
y used?=C2=A0 It has been a few years since I last dug into the menu code.<=
br>
<br>
Does anyone know if the menu translation stuff actually works?=C2=A0 Was th=
e goal to have translations for the default menus?<span class=3D"gmail-HOEn=
Zb"><font color=3D"#888888"><br>
<br>
<br>
-Dan<br>
<br>
<br>
<br>
<br>
</font></span></blockquote></div><br></div></div>

--001a114435b82c5bfe0545320825--