X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
Message-ID: <20151225102357.16247.qmail@stuge.se>
Date: Fri, 25 Dec 2015 11:23:57 +0100
From: "Peter Stuge (peter AT stuge DOT se) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
To: geda-user AT delorie DOT com
Subject: Re: [geda-user] Building pcb on Solaris
Mail-Followup-To: geda-user AT delorie DOT com
References: <567D1175 DOT 3030705 AT tio DOT cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <567D1175.3030705@tio.cz>
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

Hi Jan,

Jan Damborsky wrote:
> Deploying those tools on Solaris is straightforward, I justneed to deal
> with a small issue when building pcb - compilation fails due to following
> files missing <locale.h> header:
>
> $ git status -s
> M src/hid/gtk/gui-config.c
> M src/hid/gtk/gui-misc.c
> M src/hid/gtk/gui-netlist-window.c
> M src/main.c
> M src/print.c
> M src/report.c
>
> Adding <locale.h> to those filessolves the problem.
> Tried that on Linux as well (Ubuntu 14.04), but Linux doesn't complain
> which is perhaps the reason why that issue has not been reported so far.
> I am wondering if it would make sense to file bug for this and fix that.

I think so, we still need to find the right way to fix it.

> If desired, I am willing to do whatever is needed to integrate
> those changes into the upstream, just would need some guidance
> to go through the processes.

Filing a bug is a good first step. Next steps would be:

* find out why locale.h is required
* find out whether that is correct
+ if no, find what to do instead and implement that
+ if yes, check for locale.h in configure.ac and add #include within
  #if HAVE_LOCALE_H in the source files where locale.h is required
* commit locally
* either: git format-patch -1, then attach patch to the bug
  or: git push to somewhere and ask here for review+possible merge


//Peter