On Wed, Dec 16, 2015 at 11:12 AM, DJ Delorie <dj AT delorie DOT com> wrote:

> > I note you use // for comments.=C2=A0 If we're going this rou= te, we should
> > update configure to test for a C99-compliant compiler.
>
> This is probably a pretty safe assumption now.

Still, a check would be nice.

> It bugs me too.=C2=A0 The C alternatives I'm aware of are:

#define Point Vec

Fun= ny what you don't think of.=C2=A0 Seems a good way, no need for the com= piler to know what's going on in this case.=C2=A0 At first I though thi= s would break down for the signatures of functions that take arguments whic= h could be either Point or Vec, but I think I got over it.=C2=A0 This seems= to be saying that Point is-a Vec (implicitly from 0, so restricted in a se= nse), which means routines that would take a supertype if one existed (e.c.= vec_from()) can still use Vec in argument signatures without the choice be= ing arbitrary.=C2=A0 So it's like it is now with Vec the supertype, onl= y you can specify the more specific Point sub-type many places for readabil= ity.

=C2=A0

> > I think the debug markers should either be removed for now, or > > "completed" - added to all HIDs and documented with som= e
> > programmer-specific documentation.
>
> Would you settle for stubs in the non-gtk HIDs, and programmer
> documentation?
> It's not obvious to me how to do it in lesstif and I have no real = motivation
> to figure it out.=C2=A0 What do you mean by programmer documentation b= esides
> comments in hid.h?

Sure.=C2=A0 At the moment, it's just a couple extra functions th= at nobody
calls and aren't documented.=C2=A0 I still don't really know what t= hey're
used for...

Any time you mak= e a geometrical calculation that spits out something that can be represente= d with a point or two, its an easy way to check if it's doing what is e= xpected regardless of scale or background color.=C2=A0 So you can easily ch= eck intermediate results and such.=C2=A0 I tried to document them by commen= ting them in hid.h.=C2=A0 If the comments don't make it clear what they= are for please advise how to change them.=C2=A0 Where would you like them = documented besides hid.h?

=C2=A0

> > The right way to ignore square flags on arcs is to update the fla= g
> > parsing table so that it's not in the supported flags... oh w= ait, it's
> > already ignored there.
>
> I didn't find this table... so I can just take out all the square = arc stuff
> and it should do the right thing (though a message would be nice reall= y)?

strflags.c

There are a lot of unsupported flags that we don't error (or warn)
for, if you want to add warnings for them, go for it :-)

Ok, I've done this.=C2=A0 I just added som= e code to complain and clear the flag if it's type doesn't support = it according to the tables.

For now its only called fo= r arcs but can be added for other types later.

Britton