X-Authentication-Warning: delorie.com: mailnull set sender to djgpp-workers-bounces using -f
From: sandmann AT clio DOT rice DOT edu (Charles Sandmann)
Message-Id: <10112251834.AA25246@clio.rice.edu>
Subject: Re: Glob fix in new test version; +bash 2.04 change; now what?
To: eliz AT is DOT elta DOT co DOT il (Eli Zaretskii)
Date: Tue, 25 Dec 2001 12:34:55 -0600 (CST)
Cc: djgpp-workers AT delorie DOT com
In-Reply-To: <Pine.SUN.3.91.1011225100000.3951M-100000@is> from "Eli Zaretskii" at Dec 25, 2001 10:00:32 AM
X-Mailer: ELM [version 2.5 PL2]
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> > I did a complete rebuild from scratch on the binaries to get a new set of
> > ident dates.  I'm waiting for opinions on what we should do.  (Wait on
> > the current refresh for more reports?  Replace it with new refresh binaries?
> > Rebuild the rest of the distributions?)
> 
> I'd say replace with the new refresh.

I've saved the old binaries just in case in the "preglob" sub-directory,
and rebuilt/replaced everything on clio with new binaries built with 
the new libraries.

> > What is the risk of adding this to the refresh vs. leaving the bug in?
>
> The risk of adding it is IMHO negligible, since the change simply tests a 
> pointer against a fixed value and bails out if the test fails.

I agree, but I've been burned with simple changes biting me :-)

> The risk of leaving the bug in is that people will not be able to build 
> Bash without either resorting to local hacks, or using the CVS library.  

Bash 2.04 protected against it, bash 2.05 won't build with V2.03 anyway.
But I updated the bsh204s.zip to disable the check and put a new bsh204b
up.

> So my advice would be to add it.

It was such an evil bug (stack overflow) with such potentially terrible
consequences, and a seemingly simple fix I didn't see a good reason not
to include it.  Other than the 4 hours I spent rebuilding everything and
building new distributions ...