Message-ID: <007601c150df$50c4fa20$3e8224d5@zephyr>
From: "Eric Botcazou" <ebotcazou AT libertysurf DOT fr>
To: <djgpp-workers AT delorie DOT com>
References: <200110091438 DOT QAA23042 AT lws256 DOT lu DOT erisoft DOT se>
Subject: Re: _findfirst() patch
Date: Tue, 9 Oct 2001 18:23:55 +0200
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 5.00.2014.211
X-MimeOLE: Produced By Microsoft MimeOLE V5.00.2014.211
Reply-To: djgpp-workers AT delorie DOT com

> May I suggest you post the diffs yourself next time. It makes it much
> easier to discuss them.

Aren't there people who use their WAP mobile phone to read the list ? On the
Allegro Developers list, big patches are not welcomed. But ok, now I know...

> time_t __dostime_to_time_t(unsigned short dosdate, unsigned short dostime)
>
> This one is undocumented. Document it. And break it out into its own
> file. Others perhaps can give some reasonable place to put it.

Afaics, src/libc/dos/errno/doserr2e.c:__doserr_to_errno() is not very
documented either. What is the rule ?

Either way, I'll document it as soon as I know where to put it.

> The formal arguments in prototypes should have "_" prepended.

I had initially intended to put the underscore but then I remarked it was
not really mandatory (chsize(), snprintf(), vsnprintf(), ...).

--
Eric Botcazou
ebotcazou AT multimania DOT com