From: Martin Stromberg <Martin DOT Stromberg AT epl DOT ericsson DOT se>
Message-Id: <200110091438.QAA23042@lws256.lu.erisoft.se>
Subject: Re: _findfirst() patch
To: djgpp-workers AT delorie DOT com
Date: Tue, 9 Oct 2001 16:38:02 +0200 (MET DST)
In-Reply-To: <200110091305.PAA22981@lws256.lu.erisoft.se> from "Martin Stromberg" at Oct 09, 2001 03:05:05 PM
X-Mailer: ELM [version 2.5 PL3]
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> diff -Nu /cvsroot/djgpp/src/libc/dos/io/_findfir.c /djgpp-cvs/src/libc/dos/io/_findfir.c
> --- /cvsroot/djgpp/src/libc/dos/io/_findfir.c	Thu Jan  1 00:00:00 1970
> +++ /djgpp-cvs/src/libc/dos/io/_findfir.c	Tue Oct  9 10:29:10 2001
> @@ -0,0 +1,113 @@
> +#include <libc/stubs.h>
> +#include <libc/dosio.h>
> +#include <stdlib.h>
> +#include <string.h>
> +#include <errno.h>
> +#include <time.h>
> +#include <fcntl.h>
> +#include <go32.h>
> +#include <dpmi.h>
> +#include <dir.h>
> +#include <io.h>
> +
> +extern time_t __dostime_to_time_t(unsigned short dosdate, unsigned short dostime);
> +
> +time_t __dostime_to_time_t(unsigned short dosdate, unsigned short dostime)
> +{

This one is undocumented. Document it. And break it out into its own
file. Others perhaps can give some reasonable place to put it.

...

> --- /cvsroot/djgpp/include/io.h	Thu Feb  1 20:39:54 2001
> +++ /djgpp-cvs/include/io.h	Tue Oct  9 11:00:12 2001
> @@ -24,6 +36,9 @@
>  int		_dos_lock(int _fd, long _offset, long _length);
>  int		_dos_lk64(int _fd, long long _offset, long long _length);
>  long		filelength(int _handle);
> +long		_findfirst(const char *pathname, struct _finddata_t *fileinfo);
> +int		_findnext(long handle, struct _finddata_t *fileinfo);
> +int		_findclose(long handle);

The formal arguments in prototyes should have "_" prepended.


Right,

						MartinS