Date: Sat, 17 Feb 2001 14:26:37 +0200
From: "Eli Zaretskii" <eliz AT is DOT elta DOT co DOT il>
Sender: halo1 AT zahav DOT net DOT il
To: lauras AT softhome DOT net
Message-Id: <3791-Sat17Feb2001142636+0200-eliz@is.elta.co.il>
X-Mailer: Emacs 20.6 (via feedmail 8.3.emacs20_6 I) and Blat ver 1.8.6
CC: djgpp-workers AT delorie DOT com
In-reply-to: <20010217091528.4337.qmail@softhome.net> (lauras@softhome.net)
Subject: Re: djtar: skipping directories
References: <20010216102653 DOT 32267 DOT qmail AT softhome DOT net>
            <2110-Sat17Feb2001094540+0200-eliz AT is DOT elta DOT co DOT il> <20010217091528 DOT 4337 DOT qmail AT softhome DOT net>
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> From: lauras AT softhome DOT net
> Date: Sat, 17 Feb 2001 09:15:28 GMT
> 
> > Shouldn't you simply use xmalloc?
> 
> xmalloc() is some other function in djtar. From zlib, IIRC.

No, it's from gzip, and djtar already uses it even outside the sources
which came from gzip.  I don't see why couldn't you use it, maybe I'm
missng something.

> > That is, you want to skip that file or directory.  Given this line,
> > the above code would skip all files whose names begin with
> > "/foo/bar/baz", including, for example, "/foo/bar/bazilicum.c" and
> > "/foo/bar/bazillion/xyzzy".
> 
> Errm... And this is wrong?

Yes, I think so.

> But this is the behaviour `-o' documentation suggests.

The behavior of -o is intentionally different: it was meant to be used
as a replacement for a wildcard.  But omitting a single file or
directory is such a frequent need that it is IMHO unwise to ask the
user to type the traling slash explicitly.  I think the default
behavior in the code you sent will surprise people.