Date: Wed, 14 Feb 2001 09:15:15 +0200 (IST)
From: Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>
X-Sender: eliz AT is
To: Alain Magloire <alain AT qnx DOT com>
cc: Juan Manuel Guerrero <ST001906 AT HRZ1 DOT HRZ DOT TU-Darmstadt DOT De>,
        djgpp-workers AT delorie DOT com
Subject: Re: [alain AT qnx DOT com: GNU_grep-2.5b_beta]
In-Reply-To: <200102140446.XAA17081@qnx.com>
Message-ID: <Pine.SUN.3.91.1010214091443.9705G-100000@is>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk


On Tue, 13 Feb 2001, Alain Magloire wrote:

> > on win95 using command.com and on msdos 6.22 using 4dos.com and
> > command.com. All targets worked ok after 2 bugs had been fixed.
> > 
> > The file djgpp/config.bat is broken, making configuration impossible
> > on msdos 6.22 if 4dos.com is used as shell. This has been fixed.
> 
> I do not have enough DOS knowledge to comment intelligently, so unless
> someone say otherwise,  I will apply the patch for config.bat.

The patch looks good to me, so I think you can apply it.

Note that this patch is mostly not a bugfix per se: it actually
introduces a new feature--support for the alternative DOS shell called
4DOS when running the configury stuff.  I myself never use 4DOS,
that's why the original batch file didn't support it.

> You did not provide a ChangeLog entry for your patch so I'll assume that
> the "From:" header field contain the right info for the THANKS and
> ChangeLog files.

Juan, please try in the future to send a ChangeLog entry together with
changes.  Some maintainers of GNU packages won't accept changes
without a suitable ChangeLog entry.  The file standards.info includes
a section on writing good ChangeLog entries.