X-Authentication-Warning: sirppi.helsinki.fi: peuha owned process doing -bs Date: Thu, 19 Aug 1999 10:28:26 +0300 (EET DST) From: Esa A E Peuha Sender: peuha AT cc DOT helsinki DOT fi To: Eli Zaretskii cc: djgpp-workers AT delorie DOT com, "Paul D. Smith" Subject: Re: Make 3.78 is in pretest In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Reply-To: djgpp-workers AT delorie DOT com X-Mailing-List: djgpp-workers AT delorie DOT com X-Unsubscribes-To: listserv AT delorie DOT com Precedence: bulk On Wed, 18 Aug 1999, Eli Zaretskii wrote: > Esa, some of the tests that you said failed for you, worked for me; I > presume this is because I used the pretest of Make 3.78, and built it > with v2.03 library, where the bug in the `system' function is fixed. > The tests that didn't work for me out of the box are: That's the result I get with the executable you sent me, except for the following tests (they work for me): > features/echoing > targets/clean > Yet another problem with test_driver.pl is the trick with ".ostest>ick" > file. This works on DOS, because Esa's changes make the script skip this > part (.ostest cannot be created on DOS), but fails on Windows, since `>' > is not allowed in file names. I didn't realize Windows doesn't allow `>' in file names. > 1) features/default_names > The problem here is that Makefile and makefile map to the same file > on DOS/Windows. The solution I suggest is to generate each > standard makefile just before it is used, as opposed to generating > them all and then running them all: But that would partly defeat the purpose of the test, which is to make sure that Make searches for the standard makefiles in specific order. I think this should first test whether Makefile and makefile map to different files, and then skip creating and testing makefile if they don't. (Even on DOS it's reasonable to test that Make prefers GNUMakefile over Makefile.) > 3) features/echoing > This test uses "..." as part of the command line passed to `echo'. > But "..." is a wildcard in DJGPP (it recursively expands to all the > subdirectories of the current directory), so it didn't work. I > changed the command line to make "..." part of another argument: > 14) targets/clean > This uses "...", see features/echoing above. Here's the patch: How come these don't work for you? I changed these tests so that the script actually runs the echo command precisely to avoid this problem. The only reason I can think of is that "..." is expanded differently when echo is run by Make and by Perl on your machine, but how could that be possible, especially since it works fine for me? Anyway, there's no reason why the scripts should run echo if the command line is changed as you suggest. -- Esa Peuha student of mathematics at the University of Helsinki http://www.helsinki.fi/~peuha/