Date: Sun, 23 May 1999 12:23:27 +0300 (IDT)
From: Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>
X-Sender: eliz AT is
To: Martin Str|mberg <ams AT ludd DOT luth DOT se>
cc: snowball3 AT bigfoot DOT com, DJGPP-WORKERS <djgpp-workers AT delorie DOT com>
Subject: Re: Bash 2.03 final beta available
In-Reply-To: <199905221305.PAA02803@father.ludd.luth.se>
Message-ID: <Pine.SUN.3.91.990523122237.26578F-100000@is>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Reply-To: djgpp-workers AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk


On Sat, 22 May 1999, Martin Str|mberg wrote:

> Rename "config.h.in" to "config.h-in".

Is this enough?  Usually, there are some targets in various Makefile's
which refer to config.h.in, and these should be changed as well.

> (I have made changes to configure; that's as far back in the chain
> makefile, configure, autoconf(?)

They should go into configure.in.

> Remove "config.cache" and run "./configure".

`config.cache' should not be part of a source distribution, because it
will bite those users who want to reconfigure.

> -TMPDIR=/tmp
> +if test "x$TMPDIR" == x; then
> +    TMPDIR=/tmp
> +fi

What will it take to make GNU maintainers understand that /tmp is not
universally available??  (Don't answer that ;-).

Btw, this is simpler:

     TMPDIR=${TMPDIR='/tmp'}

>  for ac_file in .. $CONFIG_HEADERS; do if test "x$ac_file" != x..; then
> -  # Support "outfile[:infile[:infile...]]", defaulting infile="outfile.in".
> +  # Support "outfile[:infile[:infile...]]", defaulting infile="outfile-in".
>    case "$ac_file" in
>    *:*) ac_file_in=`echo "$ac_file"|sed 's%[^:]*:%%'`
>         ac_file=`echo "$ac_file"|sed 's%:.*%%'` ;;
> -  *) ac_file_in="${ac_file}.in" ;;
> +  *) ac_file_in="${ac_file}-in" ;;
>    esac

It is IMHO easier to use the feature than to tweak it.  Simply saying
config.h:config.h-in in the line that sets $CONFIG_HEADERS is all it
takes.  (A similar line needs to be added to the relevant rules in
Makefile's, see above.)

> -#include <y.tab.h>	/* use <...> so we pick it up from the build directory */
> +#include <y-tab.h>	/* use <...> so we pick it up from the build directory */

I think the DJGPP port of Bison generates y_tab.[ch] by default, so it
might be better to use the underscore instead of the dash.

> -CSOURCES = shell.c eval.c parse.y general.c make_cmd.c print_cmd.c y.tab.c \
> +CSOURCES = shell.c eval.c parse.y general.c make_cmd.c print_cmd.c y-tab.c \

Likewise.