X-Authentication-Warning: delorie.com: mail set sender to djgpp-workers-bounces using -f
X-Recipient: djgpp-workers AT delorie DOT com
Date: Wed, 05 Dec 2012 05:45:03 +0200
From: Eli Zaretskii <eliz AT gnu DOT org>
Subject: Re: src/debug/fsdb/fullscr.c r1.12
In-reply-to: <50BE6FD2.7090300@gmx.de>
X-012-Sender: halo1 AT inter DOT net DOT il
To: djgpp-workers AT delorie DOT com
Cc: sezeroz AT gmail DOT com
Message-id: <83a9ttqi0w.fsf@gnu.org>
References: <CAA2C=vA8kNDh=c5jXJ1r0TxVPuvKz-QViG222j=oDghS-UxeLA AT mail DOT gmail DOT com> <CAA2C=vD+ykMBRW2wBsSbgD83VjjediRt=eCZbMy4aQXS1fkG2g AT mail DOT gmail DOT com> <50BE474B DOT 9000204 AT gmx DOT de> <83ip8hr51z DOT fsf AT gnu DOT org> <CAA2C=vCdzUiS1c87eECfRjkbYXWn_B318oimm9gFSxGsRHbE2g AT mail DOT gmail DOT com> <83d2ypr2dw DOT fsf AT gnu DOT org> <50BE6FD2 DOT 7090300 AT gmx DOT de>
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> Date: Tue, 04 Dec 2012 22:49:06 +0100
> From: Juan Manuel Guerrero <juan DOT guerrero AT gmx DOT de>
> CC: Eli Zaretskii <eliz AT gnu DOT org>, Ozkan Sezer <sezeroz AT gmail DOT com>
> 
> A new patch ignoring the return value of the function.
> 
> diff -aprNU5 djgpp.orig/src/debug/fsdb/fullscr.c djgpp/src/debug/fsdb/fullscr.c
> --- djgpp.orig/src/debug/fsdb/fullscr.c    2012-12-01 04:29:46 +0000
> +++ djgpp/src/debug/fsdb/fullscr.c    2012-12-04 22:21:24 +0000
> @@ -855,11 +855,11 @@ select_source_file (char *file)
> 
>   static int
>   code_skip (int origin, int count)
>   {
>     int len, *next, i, j, k, instcount, done, leave;
> -  char *state, *source /* , *inst */;
> +  char *state, *source;
> 
>     if (count >= 0)
>       {
>         while (count-- > 0)
>       if (valid_instaddr (origin))
> @@ -887,13 +887,11 @@ code_skip (int origin, int count)
>           {
>             done++;
>             j = origin - done;
>             if (valid_instaddr (j))
>           {
> -#if 0
> -          inst = unassemble_proper (j, &len);
> -#endif
> +          unassemble_proper (j, &len);
>             source = unassemble_source (j);
>             next[done] = j + len;
>             if (source)
>               {
>                 leave = 0;
> @@ -907,13 +905,13 @@ code_skip (int origin, int count)
>                    code we don't need this.  */
>   #if 0
>                 leave = (strncmp (inst, "jmp", 3) == 0
>                      || strncmp (inst, "ret", 3) == 0
>                      || strncmp (inst, "iret", 4) == 0);
> -              if (!leave)
> -                inst = unassemble_proper (j, &len);
>   #endif
> +              if (!leave)
> +                unassemble_proper (j, &len);
>               }
>               }
>           }
>             else
>           {
> 

Fine with me, thanks.