X-Authentication-Warning: delorie.com: mailnull set sender to djgpp-workers-bounces using -f
From: Martin Str|mberg <ams AT ludd DOT luth DOT se>
Message-Id: <200203021641.RAA04749@father.ludd.luth.se>
Subject: Re: gcc 3.03 and libc sources
In-Reply-To: <200112271404.PAA16127@father.ludd.luth.se> from Martin Str|mberg at "Dec 27, 2001 03:04:14 pm"
To: djgpp-workers AT delorie DOT com
Date: Sat, 2 Mar 2002 17:41:05 +0100 (MET)
X-Mailer: ELM [version 2.4ME+ PL54 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

Index: djgpp//src/libc/dos/process/dosexec.c
===================================================================
RCS file: /cvs/djgpp/djgpp/src/libc/dos/process/dosexec.c,v
retrieving revision 1.19
diff -p -u -r1.19 dosexec.c
--- djgpp//src/libc/dos/process/dosexec.c       2001/08/21 03:22:46     1.19
+++ djgpp//src/libc/dos/process/dosexec.c       2002/03/02 16:34:11
@@ -1007,7 +1007,7 @@ static int go32_exec(const char *program
   /* Starting from DJGPP v2.04, programs are always run through !proxy.
      This allows correctly handle symlinks to .exes. */
   if (!check_talloc(found_si ?
-                   type->stubinfo->struct_length : 0
+                   (unsigned int)(type->stubinfo->struct_length) : 0
                    + (argc+1)*sizeof(short)))
   {
     argv[0] = save_argv0;

The only one left in libc to make it compile with -Wundef -Wcast-align
-Wsign-compare.

To refesh everyone memories, -Wsign-compare makes gcc complain "signed
and unsigned type in conditional expression" because we have statement
like "bool ? signed : unsigned".

Now that I've thought about it, I think it makes sense that both types
on each side of ":" must be the same. As this is part of an expression,
one of them must be converted to the other's type for the evaluation
of the whole expression. So the warning is justified.

It can be discussed whether -Wsign-compare should activate this
checking, though.


Right,

						MartinS