X-Authentication-Warning: delorie.com: mailnull set sender to djgpp-workers-bounces using -f
Date: Wed, 09 Jan 2002 18:11:43 +0200
From: "Eli Zaretskii" <eliz AT is DOT elta DOT co DOT il>
Sender: halo1 AT zahav DOT net DOT il
To: sandmann AT clio DOT rice DOT edu (Charles Sandmann)
Message-Id: <6137-Wed09Jan2002181142+0200-eliz@is.elta.co.il>
X-Mailer: emacs 21.1.50 (via feedmail 8 I) and Blat ver 1.8.9
CC: djgpp-workers AT delorie DOT com
In-reply-to: <10201091558.AA15635@clio.rice.edu> (sandmann@clio.rice.edu)
Subject: Re: Proposed lstat.c patch for Win2000/XP device bit fix
References:  <10201091558 DOT AA15635 AT clio DOT rice DOT edu>
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> From: sandmann AT clio DOT rice DOT edu (Charles Sandmann)
> Date: Wed, 9 Jan 2002 09:58:01 -0600 (CST)
> 
> stat_assist already uses the exact same strcmp() call elsewhere in
> the program, so the string "LFN32" is already in the image.  If we were
> obsessed with size and speed I'd say to use a cast and compare to
> "LFN3" as a long.  But right now this is more understandable, rarely
> run, and similar to other code in the module.

FWIW, I don't see any problem to have another "LFN32" in the image.

When constant strings are used by several library functions, we could
also use a global constant string instead.  system.c uses such
method, for example.