Date: Fri, 02 Mar 2001 12:46:59 +0200
From: "Eli Zaretskii" <eliz AT is DOT elta DOT co DOT il>
Sender: halo1 AT zahav DOT net DOT il
To: Richard Dawe <rich AT phekda DOT freeserve DOT co DOT uk>
Message-Id: <1438-Fri02Mar2001124659+0200-eliz@is.elta.co.il>
X-Mailer: Emacs 20.6 (via feedmail 8.3.emacs20_6 I) and Blat ver 1.8.6
CC: djgpp-workers AT delorie DOT com
In-reply-to: <3A9EB0E5.D8CE3E05@phekda.freeserve.co.uk> (message from Richard
	Dawe on Thu, 01 Mar 2001 20:28:21 +0000)
Subject: Re: strtol fix correct?
References: <Pine DOT SUN DOT 3 DOT 91 DOT 1010301155349 DOT 7052C-100000 AT is> <3A9EB0E5 DOT D8CE3E05 AT phekda DOT freeserve DOT co DOT uk>
Reply-To: djgpp-workers AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: djgpp-workers AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

> Date: Thu, 01 Mar 2001 20:28:21 +0000
> From: Richard Dawe <rich AT phekda DOT freeserve DOT co DOT uk>
> 
> I patched a copy of DJGPP CVS and ran the tests. The summary info is:
> 
>     Tested 63223 functions, 410 errors detected

Thanks.

> The section around strtol()'s test looks like this:
> 
> ...
> testing ecvtbuf
> testing ecvt/ecvtf
> testing strtod
> testing nan
> testing nan print
> testing nanf
> testing nanf print
> testing infinity
> testing infinity print
> testing infinityf
> testing infinityf print
> testing scanf
> testing sprintf
> testing atof
> testing atoff
> testing strtodf
> testing atoi
> testing atol
> testing strtol
> testing strcmp
> testing strcpy
> ...
> 
> so Hans-Bernhard's fix appears to be OK. I can send the whole test
> results, if you're interested.

The above snippet is not enough.  All the *printf and *scanf tests are
also relevant, since *scanf invoke the strto* functions, and *printf
functions are tested by calling strto* (at least sometimes).

Also, just inspecting the results for error messages is not enough
either: you need to diff against the file `standard.results' in the
djtst distro and look for changes.  Any difference is potentially some
bug that needs to be explained.