Message-ID: <39AEBA9E.A3E011AF@softhome.net>
Date: Thu, 31 Aug 2000 22:05:50 +0200
From: Laurynas Biveinis <lauras AT softhome DOT net>
X-Mailer: Mozilla 4.74 [en] (Win98; U)
X-Accept-Language: lt,en
MIME-Version: 1.0
To: Jason Green <mail AT jgreen4 DOT fsnet DOT co DOT uk>
CC: Eli Zaretskii <eliz AT is DOT elta DOT co DOT il>, djgpp-workers AT delorie DOT com
Subject: Re: Symify fixes
References: <226lqssqgqp6i9nk82rvrqhl9aaia029e9 AT 4ax DOT com> <7458-Mon28Aug2000203504+0300-eliz AT is DOT elta DOT co DOT il> <ltflqs8ouggncaukmesirq7rsbsi4umrj5 AT 4ax DOT com> <8011-Mon28Aug2000234727+0300-eliz AT is DOT elta DOT co DOT il> <ttvnqs0p0rib0eja7eiijst64vbgp9tl1b AT 4ax DOT com> <39AD1BF3 DOT 139CB5DB AT softhome DOT net> <9003-Wed30Aug2000195653+0300-eliz AT is DOT elta DOT co DOT il> <3b5rqskv9adg5lcc3p4nhg2doib859r3n8 AT 4ax DOT com> <39AE0E92 DOT C8E0A73B AT softhome DOT net> <4k7tqskuugpt8r78ls4hnt2cfhuggjdtu3 AT 4ax DOT com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Reply-To: djgpp-workers AT delorie DOT com

Jason Green wrote:
> bail() will be called due to fseek outside file boundary, or fread
> past eof; these are not failed system calls.  

Right, fseek() does not fail here. I don't know about fread.

> If you know these
> functions will always set errno=0 (no POSIX function is required to do
> that) then your code would be safe.

To be more exact, these functions do not alter errno at all, if they succeed.
But this is OK too, unless some previous system function has failed, and this
failure wasn't handled properly.

> Perhaps you
> could mail the patch first, I'll re-run the tests I did, then you can
> commit it.

OK, I sent them in a separate mail.

> There are 5 functions for putting error messages to stderr:
[...]
> The code is in apue/advio/ourhdr.h and apue/lib.44/error.c, from the
> archive http://www.kohala.com/start/apue.tar.Z

Thanks.

Laurynas