Mailing-List: contact cygwin-developers-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-developers-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-developers/>
List-Post: <mailto:cygwin-developers AT cygwin DOT com>
List-Help: <mailto:cygwin-developers-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-developers-owner AT cygwin DOT com
Delivered-To: mailing list cygwin-developers AT cygwin DOT com
Date: Wed, 22 Jan 2003 16:28:29 +0100
From: Corinna Vinschen <vinschen AT redhat DOT com>
To: cygwin-developers AT cygwin DOT com
Subject: Re: setregid() and setreuid() implementation proposal
Message-ID: <20030122152829.GG29236@cygbert.vinschen.de>
Reply-To: cygwin-developers AT cygwin DOT com
Mail-Followup-To: cygwin-developers AT cygwin DOT com
References: <20030117120131 DOT GF1142 AT cygbert DOT vinschen DOT de> <20030116190119 DOT GD820 AT tishler DOT net> <20030117120131 DOT GF1142 AT cygbert DOT vinschen DOT de> <3 DOT 0 DOT 5 DOT 32 DOT 20030121202701 DOT 007db4f0 AT mail DOT attbi DOT com> <20030122014007 DOT GA23365 AT redhat DOT com> <20030122102919 DOT GA29236 AT cygbert DOT vinschen DOT de> <20030122112419 DOT GD29236 AT cygbert DOT vinschen DOT de> <3E2EB12D DOT A2A9DD32 AT ieee DOT org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3E2EB12D.A2A9DD32@ieee.org>
User-Agent: Mutt/1.4i

On Wed, Jan 22, 2003 at 09:56:45AM -0500, Pierre A. Humblet wrote:
> Corinna Vinschen wrote:
> >
> > > But it's not *that* simple:
> > >
> > > - sec_acl.cc is still using __aclent16_t instead of __aclent32_t.
> 
> Those two structures have the same size and the same field offsets.

Really?  I missed that fact.

> Would you thumb your nose at a conversion of the style
> 
> whatever 
> aclXXX( __aclent16_t * acl)
> {
>   __aclent32_t * acl32 = acl;
>   acl32->a_id &= 0x0000FFFF;
>   return (whatever) aclXXX32(acl32);
> }
> or would you insist on alloc and copying of everything
> before and after calling the aclXXX32 function?

If the structs are same size, that's fine with me.  We just would
have to rename all external aclXXX functions to aclXXX32 and create
new aclXXX functions calling the corresponding aclXXX32 function with
converted struct.  I'm happy with this.

> > Ooops!  Another really *really* big problem:  struct stat is using
> > uids and gids as well.  Using 32 bit ids with 32 bit offset stuff
> > would require to introduce a new struct __stat32_2 plus access
> > functions.  We would have to support three variations of struct
> > stat then :-(((
> 
> :-(((

I already begged on knees that somebody would take a look into the
changes needed to newlib but...

Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin AT cygwin DOT com
Red Hat, Inc.