Mailing-List: contact cygwin-developers-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-developers-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-developers/>
List-Post: <mailto:cygwin-developers AT cygwin DOT com>
List-Help: <mailto:cygwin-developers-help AT cygwin DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-developers-owner AT cygwin DOT com
Delivered-To: mailing list cygwin-developers AT cygwin DOT com
Message-ID: <005801c2b8a2$5217f630$0201a8c0@sos>
From: "Sergey Okhapkin" <sos AT sokhapkin DOT dyndns DOT org>
To: <cygwin-developers AT cygwin DOT com>
References: <20030110130259 DOT E1401 AT cygbert DOT vinschen DOT de>
Subject: Re: gethostname() patch
Date: Fri, 10 Jan 2003 07:18:01 -0500
X-Priority: 3
X-MSMail-Priority: Normal
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2600.0000

Two notes:

1. Why do you call set_winsock_errno() but not set_errno() if
GetComputerName() failed?
2. You're comparing the return value of gethostname() with SOCKET_ERROR.
What the return value will be if TCPIP is not installed?

Sergey Okhapkin
Somerset, NJ
----- Original Message -----
From: "Corinna Vinschen" <vinschen AT redhat DOT com>
To: <cygwin-developers AT cygwin DOT com>
Sent: Friday, January 10, 2003 7:02 AM
Subject: gethostname() patch


> Hi,
>
> I've just removed some old cruft from cygwin_gethostname which had
> the annoying result that always the return value of GetComputerName()
> has been used instead of the return value of gethostname().  Now
> Cygwin's gethostname and hostname(1) report the winsock value of the
> hostname which is lower case.
>
> My questions is:  Shouldn't uname call this function as well?  Uname
> still uses the upper case value returned from GetComputerName().
>
> Corinna
>
> --
> Corinna Vinschen                  Please, send mails regarding Cygwin to
> Cygwin Developer                                mailto:cygwin AT cygwin DOT com
> Red Hat, Inc.
>