Mailing-List: contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-developers-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-developers/>
List-Post: <mailto:cygwin-developers AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-developers-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-developers-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin-developers AT sources DOT redhat DOT com
Date: Sun, 4 Nov 2001 20:57:35 -0500
From: Christopher Faylor <cgf AT redhat DOT com>
To: cygwin-developers AT cygwin DOT com
Subject: Re: 20011101 snapshot broken (also 20011103)
Message-ID: <20011104205735.A3892@redhat.com>
Reply-To: cygwin-developers AT cygwin DOT com
Mail-Followup-To: cygwin-developers AT cygwin DOT com
References: <2761-Fri02Nov2001224205+0000-starksb AT ebi DOT ac DOT uk> <5523-Sat03Nov2001082624+0000-starksb AT ebi DOT ac DOT uk> <6426-Mon05Nov2001011335+0000-starksb AT ebi DOT ac DOT uk> <s1sofmij96l DOT fsf AT jaist DOT ac DOT jp> <20011104203718 DOT A3511 AT redhat DOT com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20011104203718.A3511@redhat.com>
User-Agent: Mutt/1.3.21i

On Sun, Nov 04, 2001 at 08:37:18PM -0500, Christopher Faylor wrote:
>On Mon, Nov 05, 2001 at 10:30:42AM +0900, Kazuhiro Fujieda wrote:
>>>>> On Mon,  5 Nov 2001 01:13:34 +0000
>>>>> David Starks-Browning <starksb AT ebi DOT ac DOT uk> said:
>>
>>> However, with this snapshot, we are back to ssh-agent + ssh-add not working:
>>> 
>>>   $ eval `ssh-agent`
>>>   $ ssh-add
>>>   Could not open a connection to your authentication agent.
>>
>>I guess this is triggered by incorrect handling of unreliable
>>pipes on Win9x/Me. Please see the following example:
>>
>>$ echo `echo tako`
>>
>>$
>
>Oddly enough, both of the above work fine for me.
>
>If you have a clue about what is now incorrect in the handling of
>unreliable pipes, please share it.

I've made a minor change to the pipe reading code.  If someone could try
this and confirm/deny that it works, I'd appreciate it.

The specific change is in fhandler_pipe::read.  I'm changing the initial

  if (hiteof ())

to

  if (broken_pipe)

This essentially makes the test Windows NT specific and should revert
cygwin to the previous 1.3.4 behavior.

My theory is that my Windows 98 machines are not seeing this problem
because they are too fast.  I only have a 1GHZ and a 733MHZ system to
check this on.  I have a slower laptop that I could boot into Windows 95
but it is running another test right now.  ssh-agent doesn't work there
anyway so it wouldn't be a valid test.

If someone could change back and forth between those two cases and
verify if it fixes/causes the problem, it would be helpful.  I'm uploading
a new snapshot now.

cgf