Mailing-List: contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-developers-owner AT sources DOT redhat DOT com Delivered-To: mailing list cygwin-developers AT sources DOT redhat DOT com Date: Fri, 2 Nov 2001 23:28:16 +0300 From: egor duda X-Mailer: The Bat! (v1.53 RC/4) Reply-To: egor duda Organization: deo X-Priority: 3 (Normal) Message-ID: <13143191436.20011102232816@logos-m.ru> To: Christopher Faylor CC: cygwin-patches AT cygwin DOT com Subject: Re: -mpreferred-stack-boundary=2? In-Reply-To: <20011102001706.A10347@redhat.com> References: <20011102001706 DOT A10347 AT redhat DOT com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----------FB1755885E9E93" ------------FB1755885E9E93 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Hi! Friday, 02 November, 2001 Christopher Faylor cgf AT redhat DOT com wrote: CF> I just added the -mpreferred-stack-boundary=2 option to Makefile.common. CF> Is there a good reason not to do this? From the description in CF> gcc.info, it seems like the cases that they are talking about don't CF> affect the cygwin part of things, although it would conceivably be iffy CF> to use this switch in the newlib. CF> The code size reduction is noticeable. i have no problems with this. I'm getting a lot of "can't inline" warnings with gcc-2.95.2 due to to-be-inlined function is defined after it's called, however. gcc-3.0.2 doesn't have this problem but i wonder if it's feasible to reorganize function order to accommodate older compilers? patch attached. btw, what do you think about -Werror ? Egor. mailto:deo AT logos-m DOT ru ICQ 5165414 FidoNet 2:5020/496.19 ------------FB1755885E9E93 Content-Type: application/octet-stream; name="fix-inline-warnings.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="fix-inline-warnings.diff" SW5kZXg6IHdpbnN1cC9jeWd3aW4vZGxsX2luaXQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvaG9t ZS9kdWRhL2xvY2FsL3Zhci9taXJyb3JzL3NyYy93aW5zdXAvY3lnd2luL2RsbF9pbml0Lmgsdgpy ZXRyaWV2aW5nIHJldmlzaW9uIDEuNApkaWZmIC11IC1wIC0yIC1yMS40IGRsbF9pbml0LmgKLS0t IHdpbnN1cC9jeWd3aW4vZGxsX2luaXQuaAkyMDAxLzA5LzExIDIwOjAxOjAwCTEuNAorKysgd2lu c3VwL2N5Z3dpbi9kbGxfaW5pdC5oCTIwMDEvMTEvMDIgMjA6MTQ6MzMKQEAgLTc0LDEwICs3NCw0 IEBAIHB1YmxpYzoKICAgdm9pZCBpbml0ICgpOwogICB2b2lkIGxvYWRfYWZ0ZXJfZm9yayAoSEFO RExFLCBkbGwgKik7Ci0gIGRsbCAqaXN0YXJ0IChkbGxfdHlwZSB0KQotICB7Ci0gICAgaG9sZF90 eXBlID0gdDsKLSAgICBob2xkID0gJnN0YXJ0OwotICAgIHJldHVybiBpbmV4dCAoKTsKLSAgfQog ICBkbGwgKmluZXh0ICgpCiAgIHsKQEAgLTg2LDQgKzgwLDEwIEBAIHB1YmxpYzoKIAlicmVhazsK ICAgICByZXR1cm4gaG9sZDsKKyAgfQorICBkbGwgKmlzdGFydCAoZGxsX3R5cGUgdCkKKyAgewor ICAgIGhvbGRfdHlwZSA9IHQ7CisgICAgaG9sZCA9ICZzdGFydDsKKyAgICByZXR1cm4gaW5leHQg KCk7CiAgIH0KIH07CkluZGV4OiB3aW5zdXAvY3lnd2luL3NlY3VyaXR5LmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpS Q1MgZmlsZTogL2hvbWUvZHVkYS9sb2NhbC92YXIvbWlycm9ycy9zcmMvd2luc3VwL2N5Z3dpbi9z ZWN1cml0eS5oLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjE2CmRpZmYgLXUgLXAgLTIgLXIxLjE2 IHNlY3VyaXR5LmgKLS0tIHdpbnN1cC9jeWd3aW4vc2VjdXJpdHkuaAkyMDAxLzA5LzA3IDIxOjMy OjA1CTEuMTYKKysrIHdpbnN1cC9jeWd3aW4vc2VjdXJpdHkuaAkyMDAxLzExLzAyIDIwOjE0OjMz CkBAIC00MCw0ICs0MCwxMyBAQCBjbGFzcyBjeWdzaWQgewogCiBwdWJsaWM6CisgIGlubGluZSBv cGVyYXRvciBjb25zdCBQU0lEICgpIHsgcmV0dXJuIHBzaWQ7IH0KKworICBpbmxpbmUgY29uc3Qg UFNJRCBvcGVyYXRvcj0gKGN5Z3NpZCAmbnNpZCkKKyAgICB7IHJldHVybiBhc3NpZ24gKG5zaWQp OyB9CisgIGlubGluZSBjb25zdCBQU0lEIG9wZXJhdG9yPSAoY29uc3QgUFNJRCBuc2lkKQorICAg IHsgcmV0dXJuIGFzc2lnbiAobnNpZCk7IH0KKyAgaW5saW5lIGNvbnN0IFBTSUQgb3BlcmF0b3I9 IChjb25zdCBjaGFyICpuc2lkc3RyKQorICAgIHsgcmV0dXJuIGdldGZyb21zdHIgKG5zaWRzdHIp OyB9CisKICAgaW5saW5lIGN5Z3NpZCAoKSA6IHBzaWQgKChQU0lEKSBzYnVmKSB7fQogICBpbmxp bmUgY3lnc2lkIChjb25zdCBQU0lEIG5zaWQpIHsgKnRoaXMgPSBuc2lkOyB9CkBAIC01NSwxMSAr NjQsNCBAQCBwdWJsaWM6CiAgIGNoYXIgKnN0cmluZyAoY2hhciAqbnNpZHN0cikgY29uc3Q7CiAK LSAgaW5saW5lIGNvbnN0IFBTSUQgb3BlcmF0b3I9IChjeWdzaWQgJm5zaWQpCi0gICAgeyByZXR1 cm4gYXNzaWduIChuc2lkKTsgfQotICBpbmxpbmUgY29uc3QgUFNJRCBvcGVyYXRvcj0gKGNvbnN0 IFBTSUQgbnNpZCkKLSAgICB7IHJldHVybiBhc3NpZ24gKG5zaWQpOyB9Ci0gIGlubGluZSBjb25z dCBQU0lEIG9wZXJhdG9yPSAoY29uc3QgY2hhciAqbnNpZHN0cikKLSAgICB7IHJldHVybiBnZXRm cm9tc3RyIChuc2lkc3RyKTsgfQotCiAgIGlubGluZSBCT09MIG9wZXJhdG9yPT0gKGNvbnN0IFBT SUQgbnNpZCkgY29uc3QKICAgICB7CkBAIC03Nyw2ICs3OSw0IEBAIHB1YmxpYzoKICAgaW5saW5l IEJPT0wgb3BlcmF0b3IhPSAoY29uc3QgY2hhciAqbnNpZHN0cikgY29uc3QKICAgICB7IHJldHVy biAhKCp0aGlzID09IG5zaWRzdHIpOyB9Ci0KLSAgaW5saW5lIG9wZXJhdG9yIGNvbnN0IFBTSUQg KCkgeyByZXR1cm4gcHNpZDsgfQogCiAgIHZvaWQgZGVidWdfcHJpbnQgKGNvbnN0IGNoYXIgKnBy ZWZpeCA9IE5VTEwpIGNvbnN0CkluZGV4OiB3aW5zdXAvY3lnd2luL3NpZ3Byb2MuY2MKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQpSQ1MgZmlsZTogL2hvbWUvZHVkYS9sb2NhbC92YXIvbWlycm9ycy9zcmMvd2luc3VwL2N5 Z3dpbi9zaWdwcm9jLmNjLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjk4CmRpZmYgLXUgLXAgLTIg LXIxLjk4IHNpZ3Byb2MuY2MKLS0tIHdpbnN1cC9jeWd3aW4vc2lncHJvYy5jYwkyMDAxLzExLzAx IDIxOjE1OjUzCTEuOTgKKysrIHdpbnN1cC9jeWd3aW4vc2lncHJvYy5jYwkyMDAxLzExLzAyIDIw OjE0OjM0CkBAIC0xODAsNCArMTgwLDI3IEBAIHdhaXRfZm9yX21lICgpCiB9CiAKKy8qIEdldCB0 aGUgc3luY19wcm9jX3N1YnByb2MgbXV0byB0byBjb250cm9sIGFjY2VzcyB0bworICogY2hpbGRy ZW4sIHpvbWJpZSBhcnJheXMuCisgKiBBdHRlbXB0IHRvIGhhbmRsZSBjYXNlIHdoZXJlIHByb2Nl c3MgaXMgZXhpdGluZyBhcyB3ZSB0cnkgdG8gZ3JhYgorICogdGhlIG11dGV4LgorICovCitzdGF0 aWMgQk9PTAorZ2V0X3Byb2NfbG9jayAoRFdPUkQgd2hhdCwgRFdPUkQgdmFsKQoreworICBTdGF0 aWMgaW50IGxhc3R3aGF0ID0gLTE7CisgIGlmICghc3luY19wcm9jX3N1YnByb2MpCisgICAgcmV0 dXJuIEZBTFNFOworICBpZiAoc3luY19wcm9jX3N1YnByb2MtPmFjcXVpcmUgKFdQU1ApKQorICAg IHsKKyAgICAgIGxhc3R3aGF0ID0gd2hhdDsKKyAgICAgIHJldHVybiBUUlVFOworICAgIH0KKyAg aWYgKCFzeW5jX3Byb2Nfc3VicHJvYykKKyAgICByZXR1cm4gRkFMU0U7CisgIHN5c3RlbV9wcmlu dGYgKCJDb3VsZG4ndCBhcXVpcmUgc3luY19wcm9jX3N1YnByb2MgZm9yKCVkLCVkKSwgJUUsIGxh c3QgJWQiLAorCQkgIHdoYXQsIHZhbCwgbGFzdHdoYXQpOworICByZXR1cm4gVFJVRTsKK30KKwog c3RhdGljIEJPT0wgX19zdGRjYWxsCiBwcm9jX2Nhbl9iZV9zaWduYWxsZWQgKF9waW5mbyAqcCkK QEAgLTkzOCwyNyArOTYxLDQgQEAgZ2V0c2VtIChfcGluZm8gKnAsIGNvbnN0IGNoYXIgKnN0ciwg aW50IAogICAgIH0KICAgcmV0dXJuIGg7Ci19Ci0KLS8qIEdldCB0aGUgc3luY19wcm9jX3N1YnBy b2MgbXV0byB0byBjb250cm9sIGFjY2VzcyB0bwotICogY2hpbGRyZW4sIHpvbWJpZSBhcnJheXMu Ci0gKiBBdHRlbXB0IHRvIGhhbmRsZSBjYXNlIHdoZXJlIHByb2Nlc3MgaXMgZXhpdGluZyBhcyB3 ZSB0cnkgdG8gZ3JhYgotICogdGhlIG11dGV4LgotICovCi1zdGF0aWMgQk9PTAotZ2V0X3Byb2Nf bG9jayAoRFdPUkQgd2hhdCwgRFdPUkQgdmFsKQotewotICBTdGF0aWMgaW50IGxhc3R3aGF0ID0g LTE7Ci0gIGlmICghc3luY19wcm9jX3N1YnByb2MpCi0gICAgcmV0dXJuIEZBTFNFOwotICBpZiAo c3luY19wcm9jX3N1YnByb2MtPmFjcXVpcmUgKFdQU1ApKQotICAgIHsKLSAgICAgIGxhc3R3aGF0 ID0gd2hhdDsKLSAgICAgIHJldHVybiBUUlVFOwotICAgIH0KLSAgaWYgKCFzeW5jX3Byb2Nfc3Vi cHJvYykKLSAgICByZXR1cm4gRkFMU0U7Ci0gIHN5c3RlbV9wcmludGYgKCJDb3VsZG4ndCBhcXVp cmUgc3luY19wcm9jX3N1YnByb2MgZm9yKCVkLCVkKSwgJUUsIGxhc3QgJWQiLAotCQkgIHdoYXQs IHZhbCwgbGFzdHdoYXQpOwotICByZXR1cm4gVFJVRTsKIH0KIApJbmRleDogd2luc3VwL2N5Z3dp bi9zaWdwcm9jLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2hvbWUvZHVkYS9sb2NhbC92YXIvbWly cm9ycy9zcmMvd2luc3VwL2N5Z3dpbi9zaWdwcm9jLmgsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEu NDUKZGlmZiAtdSAtcCAtMiAtcjEuNDUgc2lncHJvYy5oCi0tLSB3aW5zdXAvY3lnd2luL3NpZ3By b2MuaAkyMDAxLzEwLzMxIDAyOjU4OjM4CTEuNDUKKysrIHdpbnN1cC9jeWd3aW4vc2lncHJvYy5o CTIwMDEvMTEvMDIgMjA6MTQ6MzQKQEAgLTc0LDcgKzc0LDQgQEAgcHVibGljOgogICAgICAgdC5n ZXRfd2luYXBpX2xvY2sgKCk7CiAgIH0KLQotICBzaWdmcmFtZSAoKTogc3QgKE5VTEwpIHt9Ci0g IHNpZ2ZyYW1lIChzaWd0aHJlYWQgJnQsIERXT1JEIGVicCA9IChEV09SRCkgX19idWlsdGluX2Zy YW1lX2FkZHJlc3MgKDApKSB7aW5pdCAodCwgZWJwKTt9CiAgIGlubGluZSB2b2lkIGluaXQgKHNp Z3RocmVhZCAmdCwgRFdPUkQgZWJwID0gKERXT1JEKSBfX2J1aWx0aW5fZnJhbWVfYWRkcmVzcyAo MCkpCiAgIHsKQEAgLTg0LDQgKzgxLDcgQEAgcHVibGljOgogICAgICAgc3QgPSBOVUxMOwogICB9 CisKKyAgc2lnZnJhbWUgKCk6IHN0IChOVUxMKSB7fQorICBzaWdmcmFtZSAoc2lndGhyZWFkICZ0 LCBEV09SRCBlYnAgPSAoRFdPUkQpIF9fYnVpbHRpbl9mcmFtZV9hZGRyZXNzICgwKSkge2luaXQg KHQsIGVicCk7fQogICB+c2lnZnJhbWUgKCkKICAgewpJbmRleDogd2luc3VwL2N5Z3dpbi9zeW5j LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2hvbWUvZHVkYS9sb2NhbC92YXIvbWlycm9ycy9zcmMv d2luc3VwL2N5Z3dpbi9zeW5jLmgsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTQKZGlmZiAtdSAt cCAtMiAtcjEuMTQgc3luYy5oCi0tLSB3aW5zdXAvY3lnd2luL3N5bmMuaAkyMDAxLzEwLzMxIDAy OjU4OjM4CTEuMTQKKysrIHdpbnN1cC9jeWd3aW4vc3luYy5oCTIwMDEvMTEvMDIgMjA6MTQ6MzQK QEAgLTIzLDQgKzIzLDkgQEAgcHVibGljOgogICBjbGFzcyBtdXRvICpuZXh0OwogICBjb25zdCBj aGFyICpuYW1lOworCisgIG11dG8oKSB7fQorICAvKiBUaGUgcmVhbCBjb25zdHJ1Y3Rvci4gKi8K KyAgbXV0byhpbnQgaW5oLCBjb25zdCBjaGFyICpuYW1lKTsKKwogICB2b2lkICpvcGVyYXRvciBu ZXcgKHNpemVfdCwgdm9pZCAqcCkge3JldHVybiBwO30KICAgdm9pZCAqb3BlcmF0b3IgbmV3IChz aXplX3QpIHtyZXR1cm4gOjpuZXcgbXV0bzsgfQpAQCAtMjgsNyArMzMsNCBAQCBwdWJsaWM6CiAJ CQkJCWN1cnJlbnRseSAqLwogCi0gIG11dG8oKSB7fQotICAvKiBUaGUgcmVhbCBjb25zdHJ1Y3Rv ci4gKi8KLSAgbXV0byhpbnQgaW5oLCBjb25zdCBjaGFyICpuYW1lKTsKICAgfm11dG8gKCk7CiAg IGludCBhY3F1aXJlIChEV09SRCBtcyA9IElORklOSVRFKSBfX2F0dHJpYnV0ZV9fICgocmVncGFy bSgxKSkpOyAvKiBBY3F1aXJlIHRoZSBsb2NrLiAqLwo= ------------FB1755885E9E93 Content-Type: application/octet-stream; name="fix-inline-warnings.ChangeLog" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="fix-inline-warnings.ChangeLog" MjAwMS0xMS0wMiAgRWdvciBEdWRhICA8ZGVvQGxvZ29zLW0ucnU+CgoJKiBkbGxfaW5pdC5oIChj bGFzcyBkbGxfbGlzdCk6IFJlb3JkZXIgZnVuY3Rpb25zIHRvIGF2b2lkIGNvbXBpbGVyCgkiY2Fu J3QgaW5saW5lIiB3YXJuaW5ncy4KCSogc2VjdXJpdHkuaCAoY2xhc3MgY3lnc2lkKTogRGl0dG8u CgkqIHNpZ3Byb2MuY2MgKGdldF9wcm9jX2xvY2spOiBEaXR0by4KCSogc2lncHJvYy5oIChjbGFz cyBzaWdmcmFtZSk6IERpdHRvLgoJKiBzeW5jLmggKGNsYXNzIG11dG8pOiBEaXR0by4K ------------FB1755885E9E93--