Mailing-List: contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-developers-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-developers/>
List-Post: <mailto:cygwin-developers AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-developers-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-developers-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin-developers AT sources DOT redhat DOT com
Date: Sat, 27 Oct 2001 20:00:34 -0700 (PDT)
From: Matt <matt AT use DOT net>
X-Sender:  <matt AT cesium DOT clock DOT org>
To: <cygwin-developers AT sources DOT redhat DOT com>
Subject: cinstall patch
Message-ID: <Pine.NEB.4.30.0110271948520.22094-200000@cesium.clock.org>
MIME-Version: 1.0
Content-Type: MULTIPART/MIXED; BOUNDARY="1916156197-873152865-1004238034=:22094"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.
  Send mail to mime AT docserver DOT cac DOT washington DOT edu for more info.

--1916156197-873152865-1004238034=:22094
Content-Type: TEXT/PLAIN; charset=US-ASCII

2001-10-27  Matt Hargett  <matt AT use DOT net>

	* geturl.cc (progress): Change int to unsigned int to eliminate
	lint warnings.

	* (get_url_to_string): Check for NULL pointer.

	* mount.cc (find2): Use free instead of delete for malloc'd
	memory.

	* nio-http.cc (NetIO_HTTP::NetIO_HTTP): Fix memory leak.



There were a few lint wanrings I wasn't sure what to do about. The warning
and my question:

geturl.cc(95) : Warning 578: Declaration of symbol 'gw_dialog' hides
symbol
    'gw_dialog' (line 40)

Is this intentional?

----
choose.cc(448) : Warning 533: function 'list_click(struct HWND__ *, int,
int,
    int, unsigned int)' should return a value (see line 402)

what should the return value be at the end of the function?

-----
choose.cc(911) : Warning 644: Variable 'n' (line 891) may not have been
    initialized

what should initial value for n be?

----
          if (src && srcsz)
choose.cc(1488) : Warning 506: Constant value Boolean

Should this be *src && *srcsz?




--
http://www.clock.org/~matt

--1916156197-873152865-1004238034=:22094
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="cinstall.diff"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine DOT NEB DOT 4 DOT 30 DOT 0110272000340 DOT 22094 AT cesium DOT clock DOT org>
Content-Description: 
Content-Disposition: attachment; filename="cinstall.diff"

PyBjeWd3aW4uZGlmZg0KSW5kZXg6IGNpbnN0YWxsL2dldHVybC5jYw0KPT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9jdnMvc3JjL3NyYy93
aW5zdXAvY2luc3RhbGwvZ2V0dXJsLmNjLHYNCnJldHJpZXZpbmcgcmV2aXNp
b24gMi43DQpkaWZmIC11IC1wIC1yMi43IGdldHVybC5jYw0KLS0tIGdldHVy
bC5jYwkyMDAxLzA1LzI4IDA4OjMxOjAyCTIuNw0KKysrIGdldHVybC5jYwky
MDAxLzEwLzI4IDAyOjQ0OjM3DQpAQCAtMTYwLDcgKzE2MCw3IEBAIHByb2dy
ZXNzIChpbnQgYnl0ZXMpDQogew0KICAgc3RhdGljIGNoYXIgYnVmWzEwMF07
DQogICBpbnQga2JwczsNCi0gIHN0YXRpYyBpbnQgbGFzdF90aWNzID0gMDsN
CisgIHN0YXRpYyB1bnNpZ25lZCBpbnQgbGFzdF90aWNzID0gMDsNCiAgIERX
T1JEIHRpY3MgPSBHZXRUaWNrQ291bnQgKCk7DQogICBpZiAodGljcyA9PSBz
dGFydF90aWNzKSAvLyB0byBwcmV2ZW50IGRpdmlzaW9uIGJ5IHplcm8NCiAg
ICAgcmV0dXJuOw0KQEAgLTIzMiw2ICsyMzIsMTIgQEAgZ2V0X3VybF90b19z
dHJpbmcgKGNoYXIgKl91cmwpDQogICAgIH0NCiANCiAgIGNoYXIgKnJ2ID0g
KGNoYXIgKikgbWFsbG9jICh0b3RhbF9ieXRlcyk7DQorICBpZiAoTlVMTCA9
PSBydikNCisgICAgew0KKyAgICAgIGxvZyAoTE9HX0JBQkJMRSwgImdldF91
cmxfdG9fc3RyaW5nKCk6IG1hbGxvYyBmYWlsZWQgZm9yIHJ2ISIpOw0KKyAg
ICAgIHJldHVybiAwOw0KKyAgICB9DQorDQogICBjaGFyICpydnAgPSBydjsN
CiAgIHdoaWxlIChidWZzICYmIGJ1ZnMtPmNvdW50ID4gMCkNCiAgICAgew0K
SW5kZXg6IGNpbnN0YWxsL21vdW50LmNjDQo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09DQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL3dpbnN1cC9jaW5zdGFsbC9t
b3VudC5jYyx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDIuNQ0KZGlmZiAtdSAt
cCAtcjIuNSBtb3VudC5jYw0KLS0tIG1vdW50LmNjCTIwMDEvMDUvMjcgMTk6
NDM6NTIJMi41DQorKysgbW91bnQuY2MJMjAwMS8xMC8yOCAwMjo0NDozOQ0K
QEAgLTYyLDcgKzYyLDcgQEAgZmluZDIgKEhLRVkgcmtleSwgaW50ICppc3Rl
eHQsIGNoYXIgKndoYQ0KICAgICAgIGlmIChSZWdRdWVyeVZhbHVlRXggKGtl
eSwgIm5hdGl2ZSIsIDAsICZ0eXBlLCAoQllURSAqKSByZXR2YWwsICZyZXR2
YWxsZW4pDQogCSAgIT0gRVJST1JfU1VDQ0VTUykNCiAJew0KLQkgIGRlbGV0
ZSByZXR2YWw7DQorCSAgZnJlZSAocmV0dmFsKTsNCiAJICByZXR2YWwgPSAw
Ow0KIAl9DQogICAgIH0NCkluZGV4OiBjaW5zdGFsbC9uaW8taHR0cC5jYw0K
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9jdnMvc3JjL3Ny
Yy93aW5zdXAvY2luc3RhbGwvbmlvLWh0dHAuY2Msdg0KcmV0cmlldmluZyBy
ZXZpc2lvbiAyLjMNCmRpZmYgLXUgLXAgLXIyLjMgbmlvLWh0dHAuY2MNCi0t
LSBuaW8taHR0cC5jYwkyMDAxLzA1LzI4IDA4OjMxOjAyCTIuMw0KKysrIG5p
by1odHRwLmNjCTIwMDEvMTAvMjggMDI6NDQ6MzkNCkBAIC05OCw2ICs5OCw3
IEBAIE5ldElPX0hUVFA6Ok5ldElPX0hUVFAgKGNoYXIgKlB1cmwsIEJPT0wN
CiANCiAgIGlmICghcy0+b2soKSkNCiAgICAgew0KKyAgICAgIGRlbGV0ZSBz
Ow0KICAgICAgIHMgPSAwOw0KICAgICAgIHJldHVybjsNCiAgICAgfQ0K
--1916156197-873152865-1004238034=:22094--