Mailing-List: contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-developers-owner AT sources DOT redhat DOT com Delivered-To: mailing list cygwin-developers AT sources DOT redhat DOT com Date: Wed, 18 Apr 2001 20:01:37 -0400 From: Christopher Faylor To: cygwin-developers AT cygwin DOT com Subject: Re: ANONYMOUS_STRUCT/UNION in w32api Message-ID: <20010418200137.A6362@redhat.com> Reply-To: cygwin-developers AT cygwin DOT com Mail-Followup-To: cygwin-developers AT cygwin DOT com References: <20010419005222 DOT X15005 AT cygbert DOT vinschen DOT de> <20010418191255 DOT A1770 AT redhat DOT com> <3ADE271F DOT E563C431 AT yahoo DOT com> <20010418194921 DOT A6060 AT redhat DOT com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.3.11i In-Reply-To: <20010418194921.A6060@redhat.com>; from cgf@redhat.com on Wed, Apr 18, 2001 at 07:49:21PM -0400 On Wed, Apr 18, 2001 at 07:49:21PM -0400, Christopher Faylor wrote: >On Wed, Apr 18, 2001 at 07:45:35PM -0400, Earnie Boyd wrote: >>Christopher Faylor wrote: >>> >>> On Thu, Apr 19, 2001 at 12:52:22AM +0200, Corinna Vinschen wrote: >>> >The latest change to w32api related to the ANONYMOUS_STRUCT and >>> >ANONYMOUS_UNION problem breaks applications which doesn't include >>> > but all needed header files separately. Each of the >>> >affected files should be able to define that stuff by themselves. >>> > >>> >May I suggest creating a new header, say "anon.h", which contains >>> >that stuff and is included by all affected files? Or, maybe it's >>> >only at the wrong place and could be moved to, say winnt.h? >>> >>> Maybe we need something more generic. Linux has something like >>> features.h but we obviously can't use that name. >>> >> >>It's a bug in cinstall source. I've sent a patch. > >Why is it a bug? It's been working for a year. > >You should be able to include individual header files. Nevermind. I just looked at the way cygwin does this. The windows.h is needed. So, I think your patch is right except that the changelog is missing function names where appropriate. Could you check your patch, with items like this: * choose.cc (create_listview): Clean up type mismatch problems. rather than * choose.cc: Clean up type mismatch problems. ? cgf