Mailing-List: contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-developers-owner AT sources DOT redhat DOT com Delivered-To: mailing list cygwin-developers AT sources DOT redhat DOT com Date: Sat, 10 Mar 2001 19:45:51 +0300 From: Egor Duda X-Mailer: The Bat! (v1.45) Personal Reply-To: Egor Duda Organization: DEO X-Priority: 3 (Normal) Message-ID: <58157083424.20010310194551@logos-m.ru> To: cygwin-developers AT cygwin DOT com Subject: Re: Outstanding issues with current DLL? In-reply-To: <20010309200616.K6430@redhat.com> References: <20010307200848 DOT A32670 AT redhat DOT com> <20010307213711 DOT E32721 AT redhat DOT com> <005801c0a811$018d6d10$0200a8c0 AT voyager> <20010308162647 DOT A4646 AT redhat DOT com> <006001c0a8eb$e3b3db90$0200a8c0 AT voyager> <20010309200616 DOT K6430 AT redhat DOT com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Hi! Saturday, 10 March, 2001 Christopher Faylor cgf AT redhat DOT com wrote: >>> > X_OK is defined as a constant unsigned in file.h cygwin_S_IEXEC.cc >>> >and /src/cygwin/src/winsup/testsuite/winsup.api/ltp/access01.c:147: >>> >gives the error: initializer element is not constant >>> > >>> >file -- access01.c >>> >.. >>> >static struct test_case_t { >>> > char *file; >>> > int mode; >>> > char *string; >>> > int experrno; >>> >} Test_cases[] = { >>> > { Fname, F_OK, "F_OK", 0 }, >>> > { Fname, X_OK, "X_OK", 0 }, <------ access01.c:147 >>> > { Fname, W_OK, "W_OK", 0 }, >>> > { Fname, R_OK, "R_OK", 0 }, >>> >}; >>> > >>> >I think X_OK has to be an int in your "interesting" changes >>> >>> Actually, to circumvent this, it has to be a constant. That would >>> blow my change out of the water. >> >>Good, but can we fix the test. I have found the tests are very good >>indicator into the health of my cygwin1.dll build i've just checked in the change to testsuite to fix this one. Egor. mailto:deo AT logos-m DOT ru ICQ 5165414 FidoNet 2:5020/496.19