Mailing-List: contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-developers-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-developers/>
List-Post: <mailto:cygwin-developers AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-developers-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/ml/#faqs>
Sender: cygwin-developers-owner AT sources DOT redhat DOT com
Delivered-To: mailing list cygwin-developers AT sources DOT redhat DOT com
Date: Thu, 7 Dec 2000 12:49:29 -0500
Message-Id: <200012071749.MAA05135@envy.delorie.com>
X-Authentication-Warning: envy.delorie.com: dj set sender to dj AT envy DOT delorie DOT com using -f
From: DJ Delorie <dj AT delorie DOT com>
To: matt AT use DOT net
CC: cygwin-developers AT sources DOT redhat DOT com
In-reply-to: <Pine.NEB.4.10.10012061643320.23344-101000@cesium.clock.org>
	(message from Matt on Wed, 6 Dec 2000 16:48:28 -0800)
Subject: Re: cygcheck patch
References:  <Pine DOT NEB DOT 4 DOT 10 DOT 10012061643320 DOT 23344-101000 AT cesium DOT clock DOT org>


> From: Matt <matt AT use DOT net>

> Changelog:

Your patch is OK, but please format your Changelog Entry like all the
rest.  Specifically, you don't disclose your full name, which is part
of the ChangeLog, entries are indented with a tab, proper
capitalization and punctuation is needed, you don't repeat the
filename for multiple changes therein, and do include the function
names.  Example:

2000-12-07  Matt Someone  <matt AT use DOT net>

	* utils/cygcheck.cc (keyeprint): Moved declaration before
	other functions so it could be used by all functions to report
	error messages.
	(add_path): Check for NULL.
	(find_on_path): Ditto.
	(init_paths): Check for errors.
	(track_down): Ditto, plus NULL.  Close memory leak.

(etc)