Mailing-List: contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-developers-owner AT sourceware DOT cygnus DOT com Delivered-To: mailing list cygwin-developers AT sourceware DOT cygnus DOT com Message-ID: <38A9E4AF.5E7C26BF@vinschen.de> Date: Wed, 16 Feb 2000 00:43:43 +0100 From: Corinna Vinschen X-Mailer: Mozilla 4.7 [en] (WinNT; I) X-Accept-Language: de,en MIME-Version: 1.0 To: cygwin-developers AT sourceware DOT cygnus DOT com CC: Reinhard Nissl Subject: Re: cygwin-src-20000125: patch to not convert cmdline to OEM References: <38A6E0D9 DOT 442DD5E9 AT gmx DOT de> <20000214165303 DOT A18925 AT cygnus DOT com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Chris Faylor wrote: > On Sun, Feb 13, 2000 at 05:50:33PM +0100, Reinhard Nissl wrote: > >the attached patch makes cygwin1.dll only convert the cmdline to OEM when the > >environment variable CYGWIN_CMD_LINE_MODE is not set to ANSI. If the variable > >doesn't exist or is set to anything else then ANSI, the library behaves as it > >did before applying the patch. > > [...] > I have a few problems with this patch. > [...] > 4) I am wondering if the conditional behavior of this code should actually be > the default behavior, i.e., should we always be using SetFileApisToANSI and > MultiByteToWideChar. > > 1 - 3 are obviously easy to fix but I'd like to get a better feel for 3. > Can some other non-US people comment on this patch? In telnet or xterm this shouldn't be a problem. But isn't it needed to set the corresponding codepage e.g. 1252 (ANSI Latin 1) instead of 850 (OEM Latin 1) if using ANSI in console window? I would suggest to try ANSI as default behaviour in the developer snapshots in the next time. It's easy to revert if we got problems. Hmm, possibly we should try it _after_ the next net release?!? Corinna