Mailing-List: contact cygwin-developers-help AT sourceware DOT cygnus DOT com; run by ezmlm
List-Unsubscribe: <mailto:cygwin-developers-unsubscribe-archive-cygwin-developers=delorie DOT com AT sourceware DOT cygnus DOT com>
List-Subscribe: <mailto:cygwin-developers-subscribe AT sourceware DOT cygnus DOT com>
List-Archive: <http://sourceware.cygnus.com/ml/cygwin-developers/>
List-Post: <mailto:cygwin-developers AT sourceware DOT cygnus DOT com>
List-Help: <mailto:cygwin-developers-help AT sourceware DOT cygnus DOT com>, <http://sourceware.cygnus.com/ml/#faqs>
Sender: cygwin-developers-owner AT sourceware DOT cygnus DOT com
Delivered-To: mailing list cygwin-developers AT sourceware DOT cygnus DOT com
From: Chris Faylor <cgf AT cygnus DOT com>
Date: Sun, 10 Oct 1999 14:09:18 -0400
To: Lincoln Myers <lincoln AT netapp DOT com>
Cc: cygwin-developers AT sourceware DOT cygnus DOT com
Subject: Re: patch submission: fixes in find_unused_handle() and cygwin_select()
Message-ID: <19991010140918.B20849@cygnus.com>
Reply-To: cygwin-developers AT sourceware DOT cygnus DOT com
Mail-Followup-To: Lincoln Myers <lincoln AT netapp DOT com>,
	cygwin-developers AT sourceware DOT cygnus DOT com
References: <199910070036 DOT RAA20891 AT herra DOT corp DOT netapp DOT com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.95.6i
In-Reply-To: <199910070036.RAA20891@herra.corp.netapp.com>; from Lincoln Myers on Wed, Oct 06, 1999 at 05:36:58PM -0700

On Wed, Oct 06, 1999 at 05:36:58PM -0700, Lincoln Myers wrote:
>	- hinfo::find_unused_handle() now accepts a start one greater
>	  than any existing descriptor, something which make_pipe()
>	  sometimes needs for the write fd, if the read fd was the
>	  last allocated.

This was actually fixed a couple of snapshots below.

>		- select_stuff::wait() no longer uses a separate copy
>		  of the fd_sets given as arguments.  If I understood
>		  the comment above cygwin_select(), it used to do
>		  this because the fd_sets given to cygwin_select()
>		  might not be a complete sizeof(fd_set) in size, but
>		  then select_stuff::wait() used to do a structure
>		  copy of r,w,s on top of readfds,writefds,exceptfds,
>		  so cygwin_select() was not really handling smaller
>		  fd_sets.

Actually, the select() comment was woefully out of date and had no
bearing on reality.  The copy was done to avoid setting anything until
the select succeeded.

>Consequently, I'm pretty sure my changes
>		  handle caller's arguments at least as gingerly, and
>		  it seems to be perl-ly correct, though I'm only
>		  hoping that implies it to be posix-ly correct...

Unfortunately, I don't think that your change duplicates the functionality
of the original code.  I'll take a look at select and see if there is
some other way to handle this.

cgf