Mailing-List: contact cygwin-apps-help AT cygwin DOT com; run by ezmlm
Sender: cygwin-apps-owner AT cygwin DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT cygwin DOT com>
List-Help: <mailto:cygwin-apps-help AT cygwin DOT com>, <http://sources.redhat.com/lists.html#faqs>
Mail-Followup-To: cygwin-apps AT cygwin DOT com
Delivered-To: mailing list cygwin-apps AT cygwin DOT com
Date: Thu, 16 May 2002 12:11:03 -0400
From: Christopher Faylor <cgf AT redhat DOT com>
To: cygwin-apps AT cygwin DOT com
Subject: Re: [PATCH] Fix for postinstall not running
Message-ID: <20020516161103.GC2893@redhat.com>
Reply-To: cygwin-apps AT cygwin DOT com
Mail-Followup-To: cygwin-apps AT cygwin DOT com
References: <FC169E059D1A0442A04C40F86D9BA7600C60D5 AT itdomain003 DOT itdomain DOT net DOT au>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <FC169E059D1A0442A04C40F86D9BA7600C60D5@itdomain003.itdomain.net.au>
User-Agent: Mutt/1.3.23.1i

On Thu, May 16, 2002 at 07:30:52PM +1000, Robert Collins wrote:
>
>
>> -----Original Message-----
>> From: Christopher Faylor [mailto:cgf AT redhat DOT com] 
>> Sent: Thursday, May 16, 2002 3:32 PM
>> To: cygwin-apps AT cygwin DOT com
>> Subject: [PATCH] Fix for postinstall not running
>> 
>> 
>> Here is a fix for the problem of postinstall not running.
>> 
>> I'm not going to check this one into the trunk because it 
>> uses a static variable and "feels wrong" as a result.  I 
>> think we probably need to change the find interface, either 
>> to just return the relative path or the full path as needed.
>
>Hmm. I think we actually want to make it more oop. It should call into
>an object, not a 'find routine'. The passed in value will be the
>relative value, and the object gets to decide whether to prepend the
>path it called find with or not.

That's exactly what I was thinking.

cgf