Mailing-List: contact cygwin-apps-help AT cygwin DOT com; run by ezmlm
Sender: cygwin-apps-owner AT cygwin DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT cygwin DOT com>
List-Help: <mailto:cygwin-apps-help AT cygwin DOT com>, <http://sources.redhat.com/lists.html#faqs>
Mail-Followup-To: cygwin-apps AT cygwin DOT com
Delivered-To: mailing list cygwin-apps AT cygwin DOT com
Date: Mon, 6 May 2002 11:39:44 +0200
From: John Marshall <johnm AT falch DOT net>
To: cygwin-apps AT cygwin DOT com
Subject: setup (patch): "add url" ui glitch
Message-ID: <20020506093944.GA1853@kahikatea.falch.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.3.27i
Organization: Falch.net

Reproducible with the current 2.192.4.26 setup.exe:

1. in the mirror selection dialog, start with no mirrors selected, so
   that the Next button is not active
2. enter a User URL and press Add
3. your new mirror is selected, but Next is not active
4. click on your selected mirror -- it stays selected, and Next magically
   activates

Suggested fix is below (I haven't tested it because I'm not set up to
build setup, but it's Fairly Trivial (tm)).  The "official" in the
comment suggests that this was once intentional, but the behaviour in
step 4 above seems to demonstrate that it doesn't make sense anymore.

2002-05-06  John Marshall  <jmarshall AT acm DOT org>

	* site.cc (SitePage::OnMessageCmd): recalculate navigation
	button activation when "Add" is pressed.
	(SitePage::CheckControlsAndDisableAccordingly): tweak comment.

--- site.cc.orig	Mon May  6 11:09:22 2002
+++ site.cc	Mon May  6 11:29:22 2002
@@ -338,7 +338,7 @@ SitePage::CheckControlsAndDisableAccordi
   // Check that at least one download site is selected.
   if (SendMessage (GetDlgItem (IDC_URL_LIST), LB_GETSELCOUNT, 0, 0) > 0)
     {
-      // At least one official site selected, enable "Next".
+      // At least one site selected, enable "Next".
       ButtonFlags |= PSWIZB_NEXT;
     }
   GetOwner ()->SetButtons (ButtonFlags);
@@ -423,6 +423,7 @@ bool SitePage::OnMessageCmd (int id, HWN
 
 	    // Update the list box.
 	    PopulateListBox ();
+	    CheckControlsAndDisableAccordingly ();
 	    eset (GetHWND (), IDC_EDIT_USER_URL, "");
 	    }
 	  }