Mailing-List: contact cygwin-apps-help AT cygwin DOT com; run by ezmlm
Sender: cygwin-apps-owner AT cygwin DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT cygwin DOT com>
List-Help: <mailto:cygwin-apps-help AT cygwin DOT com>, <http://sources.redhat.com/lists.html#faqs>
Mail-Followup-To: cygwin-apps AT cygwin DOT com
Delivered-To: mailing list cygwin-apps AT cygwin DOT com
content-class: urn:content-classes:message
Subject: RE: [teilo AT cdt DOT luth DOT se: Re: [bug?] binary mount point option in setup]
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Date: Sat, 27 Apr 2002 11:39:02 +1000
X-MimeOLE: Produced By Microsoft Exchange V6.0.5762.3
Message-ID: <FC169E059D1A0442A04C40F86D9BA7600C5F2B@itdomain003.itdomain.net.au>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
From: "Robert Collins" <robert DOT collins AT itdomain DOT com DOT au>
To: <cygwin-apps AT cygwin DOT com>
Cc: <teilo AT cdt DOT luth DOT se>
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by delorie.com id g3R1dCM26084



> -----Original Message-----
> From: Christopher Faylor [mailto:cgf AT redhat DOT com] 
> Sent: Thursday, April 11, 2002 6:17 AM
> To: cygwin-apps AT cygwin DOT com
> Subject: [teilo AT cdt DOT luth DOT se: Re: [bug?] binary mount point 
> option in setup]
> 
> 
> It isn't a proper patch, but maybe this should be 
> incorporated into setup, if it isn't already.
> 
> It seems like a valid problem.

It is, but the solution was wrong.

Index: mount.cc
===================================================================
RCS file: /cvs/cygwin-apps/setup/mount.cc,v
retrieving revision 2.12
diff -u -p -r2.12 mount.cc
--- mount.cc	26 Apr 2002 08:10:32 -0000	2.12
+++ mount.cc	27 Apr 2002 01:37:08 -0000
@@ -238,6 +238,11 @@ set_cygdrive_flags (int istext, int issy
 	{
 	  DWORD cygdrive_flags = 0;
 	  status = get_cygdrive_flags (key, &cygdrive_flags);
+	  if (status == ERROR_FILE_NOT_FOUND)
+	    {
+	      status = ERROR_SUCCESS;
+	      cygdrive_flags = default_cygdrive (key);
+	    }
 	  if (status == ERROR_SUCCESS)
 	    {
 	      set_cygdrive_flags (key, istext, cygdrive_flags);

This is a more correct solution. I'm uploading a new setup snapshot to
http://www.cygwin.com/setup-snapshots, if anone would like to test this
out.

Rob