Mailing-List: contact cygwin-apps-help AT cygwin DOT com; run by ezmlm
Sender: cygwin-apps-owner AT cygwin DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT cygwin DOT com>
List-Help: <mailto:cygwin-apps-help AT cygwin DOT com>, <http://sources.redhat.com/lists.html#faqs>
Mail-Followup-To: cygwin-apps AT cygwin DOT com
Delivered-To: mailing list cygwin-apps AT cygwin DOT com
From: "Ralf Habacker" <Ralf DOT Habacker AT freenet DOT de>
To: "Kde-Cygwin" <kde-cygwin AT kde DOT org>, "Cygwin-Apps" <cygwin-apps AT cygwin DOT com>,
   "Binutils" <binutils AT sources DOT redhat DOT com>
Subject: RE: patch for "objdump/cygwin crashes on auto-imported libs" bug
Date: Thu, 25 Apr 2002 20:27:42 +0200
Message-ID: <000001c1ec86$e4431960$625d07d5@BRAMSCHE>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3 (Normal)
X-MSMail-Priority: Normal
Importance: Normal
In-Reply-To: <002201c1ec62$b6561710$651c440a@BRAMSCHE>
X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400

Hi all,
I have applied the patch to the latest cvs release:




bfd/ChangeLog---------------------------------------

2002-04-25  Ralf Habacker  <Ralf DOT Habacker AT freenet DOT de>

	* peXXigen.c (pe_print_idata): bugfix for segfault in
        displaying auto-import image-import-descriptors



bfd/peXXigen.c---------------------------------------

$ cvs diff peXXigen.c
Index: peXXigen.c
===================================================================
RCS file: /cvs/src/src/bfd/peXXigen.c,v
retrieving revision 1.6
diff -u -3 -p -b -B -r1.6 peXXigen.c
--- peXXigen.c  30 Jan 2002 16:07:28 -0000      1.6
+++ peXXigen.c  25 Apr 2002 18:24:10 -0000
@@ -1224,7 +1224,15 @@ pe_print_idata (abfd, vfile)

          idx2 = first_thunk - adj;

-         for (j = 0; j < datasize; j += 4)
+          /* indicates that first_thunk points to an
+             data reference in the text segment (auto-import) */
+          if (idx2 < 0)
+            {
+            fprintf (file,
+             _("\tThe Import Address Table isn't identical (auto-import
descriptor)\n"));
+            differ = 1;
+            }
+          else for (j = 0; j < datasize; j += 4)
            {
              int ordinal;
              char *member_name;