Mailing-List: contact cygwin-apps-help AT cygwin DOT com; run by ezmlm
Sender: cygwin-apps-owner AT cygwin DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT cygwin DOT com>
List-Help: <mailto:cygwin-apps-help AT cygwin DOT com>, <http://sources.redhat.com/lists.html#faqs>
Mail-Followup-To: cygwin-apps AT cygwin DOT com
Delivered-To: mailing list cygwin-apps AT cygwin DOT com
From: "Ralf Habacker" <Ralf DOT Habacker AT freenet DOT de>
To: "Cygwin-Apps" <cygwin-apps AT cygwin DOT com>,
   "Binutils" <binutils AT sources DOT redhat DOT com>, "Kde-Cygwin" <kde-cygwin AT kde DOT org>
Subject: patch for "objdump/cygwin crashes on auto-imported libs" bug
Date: Thu, 25 Apr 2002 16:08:45 +0200
Message-ID: <002201c1ec62$b6561710$651c440a@BRAMSCHE>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
X-Priority: 3 (Normal)
X-MSMail-Priority: Normal
Importance: Normal
X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400

Hi all,

currently I'm working on an ordinal linking option for ld (performance benefits
for the kde-port) and have analysed the auto-import internals. While doing this
I got the knowledge to fix the bug
described in http://sources.redhat.com/ml/binutils/2002-01/msg00093.html.


$ diff -ubBp bfd/peigen.c.org bfd/peigen.c
--- bfd/peigen.c.org    Thu Apr 25 15:37:26 2002
+++ bfd/peigen.c        Thu Apr 25 15:57:50 2002
@@ -1226,7 +1226,15 @@ pe_print_idata (abfd, vfile)

          idx2 = first_thunk - adj;

-         for (j = 0; j < datasize; j += 4)
+          /* indicates that first_thunk points to an
+             data reference in the text segment (auto-import) */
+          if (idx2 < 0)
+            {
+           fprintf (file,
+            _("\tThe Import Address Table isn't identical (auto-import
descriptor)\n"));
+            differ = 1;
+           }
+         else for (j = 0; j < datasize; j += 4)
            {
              int ordinal;
              char *member_name;

bfd/ChangeLog---------------------------------------

2002-04-25  Ralf Habacker  <Ralf DOT Habacker AT freenet DOT de>

	* peigen.c (pe_print_idata): bugfix for segfault in
        displaying auto-import image-import-descriptors

Any comments ?

Ralf